Correct pseudo element type of tree pseudos. draft
authorXidorn Quan <me@upsuper.org>
Thu, 19 Oct 2017 15:51:55 +1100
changeset 683744 bbff59f2b23db52205af71f6751a580257d9ff63
parent 683743 22b992be067c02de310aa0ba5f1384d30790d9f0
child 683745 9b33c3d14c7d0e0ef535a2dca3fbe236cc22cb6f
push id85454
push userxquan@mozilla.com
push dateFri, 20 Oct 2017 05:32:42 +0000
milestone58.0a1
Correct pseudo element type of tree pseudos. MozReview-Commit-ID: 3NWYfnAdBsZ
servo/components/style/gecko/generated/pseudo_element_definition.rs
servo/components/style/gecko/pseudo_element_definition.mako.rs
--- a/servo/components/style/gecko/generated/pseudo_element_definition.rs
+++ b/servo/components/style/gecko/generated/pseudo_element_definition.rs
@@ -890,28 +890,28 @@ impl PseudoElement {
                     PseudoElement::ViewportScroll => CSSPseudoElementType_InheritingAnonBox,
                     PseudoElement::AnonymousFlexItem => CSSPseudoElementType_InheritingAnonBox,
                     PseudoElement::AnonymousGridItem => CSSPseudoElementType_InheritingAnonBox,
                     PseudoElement::Ruby => CSSPseudoElementType_InheritingAnonBox,
                     PseudoElement::RubyBase => CSSPseudoElementType_InheritingAnonBox,
                     PseudoElement::RubyBaseContainer => CSSPseudoElementType_InheritingAnonBox,
                     PseudoElement::RubyText => CSSPseudoElementType_InheritingAnonBox,
                     PseudoElement::RubyTextContainer => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeColumn(..) => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeRow(..) => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeSeparator(..) => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeCell(..) => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeIndentation(..) => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeLine(..) => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeTwisty(..) => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeImage(..) => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeCellText(..) => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeCheckbox(..) => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeProgressmeter(..) => CSSPseudoElementType_InheritingAnonBox,
-                    PseudoElement::MozTreeDropFeedback(..) => CSSPseudoElementType_InheritingAnonBox,
+                    PseudoElement::MozTreeColumn(..) => CSSPseudoElementType::XULTree,
+                    PseudoElement::MozTreeRow(..) => CSSPseudoElementType::XULTree,
+                    PseudoElement::MozTreeSeparator(..) => CSSPseudoElementType::XULTree,
+                    PseudoElement::MozTreeCell(..) => CSSPseudoElementType::XULTree,
+                    PseudoElement::MozTreeIndentation(..) => CSSPseudoElementType::XULTree,
+                    PseudoElement::MozTreeLine(..) => CSSPseudoElementType::XULTree,
+                    PseudoElement::MozTreeTwisty(..) => CSSPseudoElementType::XULTree,
+                    PseudoElement::MozTreeImage(..) => CSSPseudoElementType::XULTree,
+                    PseudoElement::MozTreeCellText(..) => CSSPseudoElementType::XULTree,
+                    PseudoElement::MozTreeCheckbox(..) => CSSPseudoElementType::XULTree,
+                    PseudoElement::MozTreeProgressmeter(..) => CSSPseudoElementType::XULTree,
+                    PseudoElement::MozTreeDropFeedback(..) => CSSPseudoElementType::XULTree,
                     PseudoElement::MozSVGMarkerAnonChild => CSSPseudoElementType_InheritingAnonBox,
                     PseudoElement::MozSVGOuterSVGAnonChild => CSSPseudoElementType_InheritingAnonBox,
                     PseudoElement::MozSVGForeignContent => CSSPseudoElementType_InheritingAnonBox,
                     PseudoElement::MozSVGText => CSSPseudoElementType_InheritingAnonBox,
         }
     }
 
     /// Get a PseudoInfo for a pseudo
--- a/servo/components/style/gecko/pseudo_element_definition.mako.rs
+++ b/servo/components/style/gecko/pseudo_element_definition.mako.rs
@@ -142,17 +142,17 @@ impl PseudoElement {
     pub fn pseudo_type(&self) -> CSSPseudoElementType {
         use gecko_bindings::structs::CSSPseudoElementType_InheritingAnonBox;
 
         match *self {
             % for pseudo in PSEUDOS:
                 % if not pseudo.is_anon_box():
                     PseudoElement::${pseudo.capitalized()} => CSSPseudoElementType::${pseudo.original_ident},
                 % elif pseudo.is_tree_pseudo_element():
-                    PseudoElement::${pseudo.capitalized()}(..) => CSSPseudoElementType_InheritingAnonBox,
+                    PseudoElement::${pseudo.capitalized()}(..) => CSSPseudoElementType::XULTree,
                 % elif pseudo.is_inheriting_anon_box():
                     PseudoElement::${pseudo.capitalized()} => CSSPseudoElementType_InheritingAnonBox,
                 % else:
                     PseudoElement::${pseudo.capitalized()} => CSSPseudoElementType::NonInheritingAnonBox,
                 % endif
             % endfor
         }
     }