Bug 1396880 - Skip not relevant checks in test_accessibility for webdriver click. draft
authorHenrik Skupin <mail@hskupin.info>
Wed, 18 Oct 2017 14:22:19 +0200
changeset 682288 b4673a7e0450b56cf84d4c509a2d9f9d52ec1fc6
parent 682167 4efa95ae9141a1973b2cdc026f315691f4e3d7ea
child 736354 65e0f1d30ea5b264c213b156ef2316e2bb94dc22
push id85060
push userbmo:hskupin@gmail.com
push dateWed, 18 Oct 2017 12:23:20 +0000
bugs1396880
milestone58.0a1
Bug 1396880 - Skip not relevant checks in test_accessibility for webdriver click. The test currently performs checks which will no longer raise the expected accessibility exceptions if the webdriver conforming click is enabled. In such a condition those specific situations are already covered in test_click.py. As long as the legacy click has not been fully removed keep running the checks but only if the webdriver click is not in use. MozReview-Commit-ID: 1DbKfJYADp
testing/marionette/harness/marionette_harness/tests/unit/test_accessibility.py
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_accessibility.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_accessibility.py
@@ -182,29 +182,33 @@ class TestAccessibility(MarionetteTestCa
                                                                 element.is_enabled))
 
         # Buttons are enabled but disabled/not-explorable via
         # the accessibility API and thus are not clickable via the
         # accessibility API.
         self.run_element_test(self.aria_disabled_elementIDs,
                               lambda element: self.assertRaises(ElementNotAccessibleException,
                                                                 element.click))
-        self.run_element_test(self.pointer_events_none_elementIDs,
-                              lambda element: self.assertRaises(ElementNotAccessibleException,
-                                                                element.click))
+        # To be removed with bug 1405967
+        if not self.marionette.session_capabilities["moz:webdriverClick"]:
+            self.run_element_test(self.pointer_events_none_elementIDs,
+                                  lambda element: self.assertRaises(ElementNotAccessibleException,
+                                                                    element.click))
 
         self.setup_accessibility(False, False)
         self.run_element_test(self.aria_disabled_elementIDs,
                               lambda element: element.is_enabled())
         self.run_element_test(self.pointer_events_none_elementIDs,
                               lambda element: element.is_enabled())
         self.run_element_test(self.aria_disabled_elementIDs,
                               lambda element: element.click())
-        self.run_element_test(self.pointer_events_none_elementIDs,
-                              lambda element: element.click())
+        # To be removed with bug 1405967
+        if not self.marionette.session_capabilities["moz:webdriverClick"]:
+            self.run_element_test(self.pointer_events_none_elementIDs,
+                                  lambda element: element.click())
 
     def test_element_is_enabled_to_accessibility(self):
         self.setup_accessibility()
         # No exception should be raised
         self.run_element_test(self.disabled_elementIDs, lambda element: element.is_enabled())
 
     def test_send_keys_raises_no_exception(self):
         self.setup_accessibility()