Bug 1204016 - Move permissions list directly underneath the section icon;r=ttaubert draft
authorBrian Grinstead <bgrinstead@mozilla.com>
Fri, 11 Sep 2015 09:38:28 -0700
changeset 292433 51a1e1d89df897fed3833d2c05eca2d43af5fd09
parent 292432 0489bb851c78e97eee7fe0cd904cd8f2e7083132
child 509213 4d0ff002314b1fda958e4567fea09f8dcbdadd97
push id5329
push userbgrinstead@mozilla.com
push dateFri, 11 Sep 2015 16:38:33 +0000
reviewersttaubert
bugs1204016
milestone43.0a1
Bug 1204016 - Move permissions list directly underneath the section icon;r=ttaubert
browser/components/controlcenter/content/panel.inc.xul
browser/themes/shared/controlcenter/panel.inc.css
--- a/browser/components/controlcenter/content/panel.inc.xul
+++ b/browser/components/controlcenter/content/panel.inc.xul
@@ -78,17 +78,18 @@
                   accesskey="&trackingProtection.block2.accesskey;"
                   oncommand="TrackingProtection.enableForCurrentPage();" />
         </vbox>
       </hbox>
 
       <!-- Permissions Section -->
       <hbox id="identity-popup-permissions" class="identity-popup-section">
         <vbox id="identity-popup-permissions-content" flex="1">
-          <label class="identity-popup-headline"
+          <label id="identity-popup-permission-headline"
+                 class="identity-popup-headline"
                  value="&identity.permissions;"/>
           <vbox id="identity-popup-permission-list"/>
         </vbox>
       </hbox>
     </panelview>
 
     <!-- Security SubView -->
     <panelview id="identity-popup-securityView" flex="1">
--- a/browser/themes/shared/controlcenter/panel.inc.css
+++ b/browser/themes/shared/controlcenter/panel.inc.css
@@ -287,15 +287,25 @@ description#identity-popup-content-verif
 #identity-popup-permissions-content {
   background-image: url(chrome://browser/skin/controlcenter/permissions.svg);
 }
 
 #identity-popup-permission-list .notification-anchor-icon {
   margin: 0;
 }
 
+.identity-popup-permission-headline {
+  /* Make sure the label is as tall as the icon so that the permission list
+     which is aligned with the icon doesn't cover it up. */
+  min-height: 24px;
+}
+
 #identity-popup-permission-list {
   margin-top: 5px;
+  /* Offset the padding set on #identity-popup-permissions-content,
+     so that it shows up just below the section. The perm icons (16px wide)
+     should be right aligned with the section icon. */
+  -moz-margin-start: calc(-1em - 16px);
 }
 
 .identity-popup-permission-label {
-  -moz-margin-start: 3px;
+  -moz-margin-start: 1em;
 }