Bug 1409341 - Apply background background to tab instead of tab-background on Windows 7. r=dao draft
authorJohann Hofmann <jhofmann@mozilla.com>
Tue, 17 Oct 2017 13:47:18 +0200
changeset 681545 17648b32055756d961535d77e86ae43c5503352a
parent 681544 ffe120cce31ac18d8cb8bd30ddd194ed766a4a48
child 736164 e11356507dd1cb53cca8839ffd4de2f4492d5c3d
push id84848
push userbmo:jhofmann@mozilla.com
push dateTue, 17 Oct 2017 11:50:03 +0000
reviewersdao
bugs1409341
milestone57.0
Bug 1409341 - Apply background background to tab instead of tab-background on Windows 7. r=dao MozReview-Commit-ID: 4llKxm1rNoq
browser/themes/windows/browser.css
browser/themes/windows/compacttheme.css
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -121,24 +121,28 @@
       color: hsl(240,9%,98%);
     }
 
     /* Always show full-height tab separators on tabs with borders. */
     .tabbrowser-tab:not(:-moz-lwtheme)::before {
       border-image: none !important;
     }
 
-    /* Show the tabs toolbar background color inside tabs on Win 7. */
-    .tab-background:not(:-moz-lwtheme):not([selected=true]) {
+    /* Show border on tabs with background colors and
+     * show the tabs toolbar background color inside tabs. */
+    .tabbrowser-tab:not(:-moz-lwtheme) {
       background-color: hsl(235,33%,19%) !important;
+      border-top: 1px solid var(--tabs-border);
+      background-clip: padding-box;
     }
 
-    /* Show border on tabs with background colors in Windows 7. */
+    /* The top border on top of the tab background is replaced
+     * by the slightly transparent outside tabs-border. */
     .tab-background:not(:-moz-lwtheme) {
-      border-top: 1px solid var(--tabs-border);
+      border-top-style: none !important;
     }
   }
 }
 
 @media (-moz-windows-compositor: 0),
        (-moz-windows-default-theme: 0) {
   /* Please keep the menu text colors in this media block in sync with
    * compacttheme.css, minus the :not(:-moz-lwtheme) condition - see Bug 1165718.
--- a/browser/themes/windows/compacttheme.css
+++ b/browser/themes/windows/compacttheme.css
@@ -71,24 +71,28 @@
     }
   }
 
   /* Always show full-height tab separators on tabs with borders. */
   .tabbrowser-tab::before {
     border-image: none !important;
   }
 
-  /* Show the tabs toolbar background color inside tabs on Win 7. */
-  .tab-background:not([selected=true]) {
+  /* Show border on tabs with background colors and
+   * show the tabs toolbar background color inside tabs. */
+  .tabbrowser-tab {
     background-color: var(--chrome-background-color) !important;
+    border-top: 1px solid var(--tabs-border);
+    background-clip: padding-box;
   }
 
-  /* Show border on tabs with background colors in Windows 7. */
+  /* The top border on top of the tab background is replaced
+   * by the slightly transparent outside tabs-border. */
   .tab-background {
-    border-top: 1px solid var(--tabs-border);
+    border-top-style: none !important;
   }
 
   /* Use default window colors when in non-maximized mode */
   #tabbrowser-tabs,
   #TabsToolbar,
   #browser-panel,
   #titlebar-content {
     background: transparent;