Bug 1408670 - Use PBU.isContentWindowPrivate instead of PBU.isBrowserPrivate in ContextMenu.jsm. r?Felipe draft
authorIan Moody <moz-ian@perix.co.uk>
Sat, 14 Oct 2017 16:43:38 +0100
changeset 682619 ee31ba2e32860b0cf84769931e16fc0f32ea19c8
parent 682254 a29052590fc6538b89641e690d11731ca8e78120
child 736388 dd688e71aceeea0bf5bbba0ef54fa3412efa5795
push id85097
push usermoz-ian@perix.co.uk
push dateWed, 18 Oct 2017 15:33:30 +0000
reviewersFelipe
bugs1408670, 1399429
milestone58.0a1
Bug 1408670 - Use PBU.isContentWindowPrivate instead of PBU.isBrowserPrivate in ContextMenu.jsm. r?Felipe Follow up correction to bug 1399429. isBrowserPrivate causes console spam, probably not e10s safe going forward. MozReview-Commit-ID: JMoTVbc3SAx
browser/modules/ContextMenu.jsm
--- a/browser/modules/ContextMenu.jsm
+++ b/browser/modules/ContextMenu.jsm
@@ -654,17 +654,17 @@ class ContextMenu {
       // used for nsContextMenu.initLeaveDOMFullScreenItems and
       // nsContextMenu.initMediaPlayerItems
       fullscreen: context.target.ownerDocument.fullscreen,
 
       // used for nsContextMenu.initMiscItems
       contentType: context.target.ownerDocument.contentType,
 
       // used for nsContextMenu.saveLink
-      isPrivate: PrivateBrowsingUtils.isBrowserPrivate(context.target.ownerDocument),
+      isPrivate: PrivateBrowsingUtils.isContentWindowPrivate(context.target.ownerGlobal),
     };
 
     // used for nsContextMenu.initMediaPlayerItems
     Object.assign(cleanTarget, {
       ended: context.target.ended,
       muted: context.target.muted,
       paused: context.target.paused,
       controls: context.target.controls,