Bug 1408872 - Enable browser_jsterm_no_autocompletion_on_defined_variables.js on the new console frontend; r=Honza. draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Tue, 17 Oct 2017 09:32:25 +0200
changeset 681387 88e635cc71b4d870b1430fd9284e643b27969e41
parent 681370 4af9df28f45455c341c11f4c8f87e4d735d52d30
child 736131 cb9c23a46bb7dcd51a284e366280a6ef132920e6
push id84810
push userbmo:nchevobbe@mozilla.com
push dateTue, 17 Oct 2017 07:33:25 +0000
reviewersHonza
bugs1408872
milestone58.0a1
Bug 1408872 - Enable browser_jsterm_no_autocompletion_on_defined_variables.js on the new console frontend; r=Honza. MozReview-Commit-ID: BrGniln0AB5
devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_no_autocompletion_on_defined_variables.js
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
@@ -198,17 +198,16 @@ skip-if = true #	Bug 1403188
 [browser_jsterm_copy_command.js]
 skip-if = true
 subsuite = clipboard
 # old console skip-if = (os == 'linux' && bits == 32 && debug) # bug 1328915, disable linux32 debug devtools for timeouts
 [browser_jsterm_dollar.js]
 [browser_jsterm_history_persist.js]
 [browser_jsterm_inspect.js]
 [browser_jsterm_no_autocompletion_on_defined_variables.js]
-skip-if = true # Bug 1408872
 [browser_jsterm_no_input_and_tab_key_pressed.js]
 [browser_netmonitor_shows_reqs_in_webconsole.js]
 [browser_webconsole.js]
 skip-if = true #	Bug 1404829
 [browser_webconsole_No_input_change_and_Tab_key_pressed.js]
 skip-if = true #	Bug 1404882
 [browser_webconsole_add_edited_input_to_history.js]
 skip-if = true # Bug 1408915
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_no_autocompletion_on_defined_variables.js
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_no_autocompletion_on_defined_variables.js
@@ -6,20 +6,17 @@
 // Tests for bug 704295
 
 "use strict";
 
 const TEST_URI = "http://example.com/browser/devtools/client/webconsole/" +
                  "test/test-console.html";
 
 add_task(function* () {
-  yield loadTab(TEST_URI);
-
-  let hud = yield openConsole();
-
+  let hud = yield openNewTabAndConsole(TEST_URI);
   testCompletion(hud);
 });
 
 function testCompletion(hud) {
   let jsterm = hud.jsterm;
   let input = jsterm.inputNode;
 
   // Test typing 'var d = 5;' and press RETURN