Bug 1409261 - Update string and add translation note for pwa badge and onboarding. r=flod draft
authorNevin Chen <cnevinchen@gmail.com>
Tue, 17 Oct 2017 13:53:55 +0800
changeset 683059 eb7f158a4fcbada2df43e1ec8877efa414877d45
parent 682832 e922e935ac5134faa70b0fef7fba088a1d253abe
child 683101 4da4c8fe47aceca19faf8fa6c69b689ea9b6918d
push id85232
push userbmo:cnevinchen@gmail.com
push dateThu, 19 Oct 2017 05:41:58 +0000
reviewersflod
bugs1409261
milestone58.0a1
Bug 1409261 - Update string and add translation note for pwa badge and onboarding. r=flod Please see attachments in the bug for details where the strings are. MozReview-Commit-ID: KUv79x7O0UW
mobile/android/base/locales/en-US/android_strings.dtd
mobile/android/base/strings.xml.in
--- a/mobile/android/base/locales/en-US/android_strings.dtd
+++ b/mobile/android/base/locales/en-US/android_strings.dtd
@@ -849,13 +849,17 @@ is simply hidden from the Activity Strea
 
 <!ENTITY private_tab_panel_title "Private Browsing + Tracking Protection">
 <!ENTITY private_tab_panel_description "&brandShortName; blocks parts of the pages that may track your browsing activity.">
 <!ENTITY private_tab_panel_description2 "We won\'t remember any history, but downloaded files and new bookmarks will still be saved to your device.">
 <!ENTITY private_tab_learn_more "Want to learn more?">
 
 <!ENTITY fullscreen_warning "Entered full screen">
 
-
+<!-- LOCALIZATION NOTE (pwa_add_to_launcher_confirm): The plus sign here is part of UI design -->
 <!ENTITY pwa_add_to_launcher_confirm "+ Add to Home Screen">
-<!ENTITY pwa_add_to_launcher_badge "Add PWA to Home Screen">
+
+<!-- LOCALIZATION NOTE (pwa_add_to_launcher_badge2): Used as label in the page actions dropdown list,
+displayed when there are more than 3 actions available for a page.
+See also https://bug1409261.bmoattachments.org/attachment.cgi?id=8919897 -->
+<!ENTITY pwa_add_to_launcher_badge2 "Add to Home Screen">
 <!ENTITY pwa_continue_to_website "Continue to Website">
 <!ENTITY pwa_onboarding_sumo "You can easily add this website to your Home screen to have instant access and browse faster with an app-like experience.">
\ No newline at end of file
--- a/mobile/android/base/strings.xml.in
+++ b/mobile/android/base/strings.xml.in
@@ -636,12 +636,12 @@
   <string name="private_tab_panel_title">&private_tab_panel_title;</string>
   <string name="private_tab_panel_description">&private_tab_panel_description;</string>
   <string name="private_tab_panel_description2">&private_tab_panel_description2;</string>
   <string name="private_tab_learn_more">&private_tab_learn_more;</string>
 
   <string name="fullscreen_warning">&fullscreen_warning;</string>
 
   <string name="pwa_add_to_launcher_confirm">&pwa_add_to_launcher_confirm;</string>
-  <string name="pwa_add_to_launcher_badge">&pwa_add_to_launcher_badge;</string>
+  <string name="pwa_add_to_launcher_badge">&pwa_add_to_launcher_badge2;</string>
   <string name="pwa_onboarding_sumo">&pwa_onboarding_sumo;</string>
   <string name="pwa_continue_to_website">&pwa_continue_to_website;</string>
 </resources>