Bug 1408568 - Handle SandboxReport::ProcType::FILE correctly in XPCOM bindings. r?gcp draft
authorJed Davis <jld@mozilla.com>
Fri, 13 Oct 2017 17:33:01 -0600
changeset 680394 552e46c6d939a907733749b94121aa3e98bc6958
parent 679629 25aad10380b10b6efa50c2b4d97245f078d870a0
child 735845 7d6217207e7a0cc718c2c15f6e9c08e36ec93058
push id84492
push userbmo:jld@mozilla.com
push dateFri, 13 Oct 2017 23:55:23 +0000
reviewersgcp
bugs1408568
milestone58.0a1
Bug 1408568 - Handle SandboxReport::ProcType::FILE correctly in XPCOM bindings. r?gcp MozReview-Commit-ID: EwNTeG4cbZG
security/sandbox/linux/reporter/SandboxReporterWrappers.cpp
toolkit/locales/en-US/chrome/global/aboutSupport.properties
--- a/security/sandbox/linux/reporter/SandboxReporterWrappers.cpp
+++ b/security/sandbox/linux/reporter/SandboxReporterWrappers.cpp
@@ -70,16 +70,19 @@ NS_IMETHODIMP SandboxReportWrapper::GetT
 
 /* readonly attribute ACString procType; */
 NS_IMETHODIMP SandboxReportWrapper::GetProcType(nsACString& aProcType)
 {
   switch (mReport.mProcType) {
   case SandboxReport::ProcType::CONTENT:
     aProcType.AssignLiteral("content");
     return NS_OK;
+  case SandboxReport::ProcType::FILE:
+    aProcType.AssignLiteral("file");
+    return NS_OK;
   case SandboxReport::ProcType::MEDIA_PLUGIN:
     aProcType.AssignLiteral("mediaPlugin");
     return NS_OK;
   default:
     MOZ_ASSERT(false);
     return NS_ERROR_UNEXPECTED;
   }
 }
--- a/toolkit/locales/en-US/chrome/global/aboutSupport.properties
+++ b/toolkit/locales/en-US/chrome/global/aboutSupport.properties
@@ -114,16 +114,17 @@ hasSeccompBPF = Seccomp-BPF (System Call
 hasSeccompTSync = Seccomp Thread Synchronization
 hasUserNamespaces = User Namespaces
 hasPrivilegedUserNamespaces = User Namespaces for privileged processes
 canSandboxContent = Content Process Sandboxing
 canSandboxMedia = Media Plugin Sandboxing
 contentSandboxLevel = Content Process Sandbox Level
 effectiveContentSandboxLevel = Effective Content Process Sandbox Level
 sandboxProcType.content = content
+sandboxProcType.file = file content
 sandboxProcType.mediaPlugin = media plugin
 
 # LOCALIZATION NOTE %1$S and %2$S will be replaced with the number of remote and the total number
 # of windows, respectively, while %3$S will be replaced with one of the status strings below,
 # which contains a description of the multi-process preference and status.
 # Note: multiProcessStatus.3 doesn't exist because status=3 was deprecated.
 multiProcessWindows = %1$S/%2$S (%3$S)
 multiProcessStatus.0 = Enabled by user