Bug 1408459, part 1 - Work around compiler problem on Android 4.2 x86 opt. r=kamidphish draft
authorAndrew McCreight <continuation@gmail.com>
Sun, 15 Oct 2017 09:19:31 -0700
changeset 680603 c59aab700e6bd218edb2cea7b7fff99bc181b60e
parent 680578 0bd9b61304e208cdd5cc489aef45fdff04a006f2
child 680604 61b6bf96082f16f84dd1fff6f942ca6a809904de
push id84560
push userbmo:continuation@gmail.com
push dateSun, 15 Oct 2017 20:42:31 +0000
reviewerskamidphish
bugs1408459
milestone58.0a1
Bug 1408459, part 1 - Work around compiler problem on Android 4.2 x86 opt. r=kamidphish Removing an ununused declaration in nsTraceRefcnt.h causes a compiler error on Android 4.2 x86 op when CubebUtils.cpp is compiled unified, for some reason. Work around this by compiling it by itself. MozReview-Commit-ID: F73D47TU32B
dom/media/moz.build
--- a/dom/media/moz.build
+++ b/dom/media/moz.build
@@ -210,17 +210,16 @@ UNIFIED_SOURCES += [
     'AudioTrack.cpp',
     'AudioTrackList.cpp',
     'BaseMediaResource.cpp',
     'Benchmark.cpp',
     'CanvasCaptureMediaStream.cpp',
     'ChannelMediaDecoder.cpp',
     'ChannelMediaResource.cpp',
     'CloneableWithRangeMediaResource.cpp',
-    'CubebUtils.cpp',
     'DOMMediaStream.cpp',
     'FileBlockCache.cpp',
     'FileMediaResource.cpp',
     'GetUserMediaRequest.cpp',
     'GraphDriver.cpp',
     'Latency.cpp',
     'MediaCache.cpp',
     'MediaContainerType.cpp',
@@ -273,18 +272,21 @@ if CONFIG['OS_TARGET'] == 'WINNT':
       'AudioNotificationSender.h',
   ]
   SOURCES += [
       'AudioNotificationReceiver.cpp',
       'AudioNotificationSender.cpp',
       'ThreadPoolCOMListener.cpp',
   ]
 
+# CubebUtils.cpp needs to be built separately due to what appears to be some kind
+# of compiler bug on Android 4.2 x86 opt. See bug 1408459.
 # DecoderTraits.cpp needs to be built separately because of Mac OS X headers.
 SOURCES += [
+    'CubebUtils.cpp',
     'DecoderTraits.cpp',
 ]
 
 # Some codec-related code uses multi-character constants, which GCC and clang
 # warn about. Suppress turning this warning into an error.
 if CONFIG['GNU_CC'] or CONFIG['CLANG_CL']:
   SOURCES['DecoderTraits.cpp'].flags += ['-Wno-error=multichar']