Bug 1387798 - rename to BufferReader. r?kinetik draft
authorAlfredo.Yang <ayang@mozilla.com>
Wed, 11 Oct 2017 15:55:15 +0800
changeset 680632 1c63e97b185612360c98e815c573288c3206c33b
parent 680631 378a478e5c1b802669d5fa11352355c4090cdd29
child 680633 c9049137b12f6159d525debad5cff22c75505a7e
push id84566
push userbmo:ayang@mozilla.com
push dateMon, 16 Oct 2017 00:30:33 +0000
reviewerskinetik
bugs1387798
milestone58.0a1
Bug 1387798 - rename to BufferReader. r?kinetik MozReview-Commit-ID: E1zhXdLEPFS
media/libstagefright/binding/include/mp4_demuxer/BufferReader.h
media/libstagefright/moz.build
--- a/media/libstagefright/binding/include/mp4_demuxer/BufferReader.h
+++ b/media/libstagefright/binding/include/mp4_demuxer/BufferReader.h
@@ -1,52 +1,52 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-#ifndef BYTE_READER_H_
-#define BYTE_READER_H_
+#ifndef BUFFER_READER_H_
+#define BUFFER_READER_H_
 
 #include "mozilla/EndianUtils.h"
 #include "nsTArray.h"
 #include "MediaData.h"
 
 namespace mp4_demuxer {
 
-class MOZ_RAII ByteReader
+class MOZ_RAII BufferReader
 {
 public:
-  ByteReader() : mPtr(nullptr), mRemaining(0) {}
-  ByteReader(const uint8_t* aData, size_t aSize)
+  BufferReader() : mPtr(nullptr), mRemaining(0) {}
+  BufferReader(const uint8_t* aData, size_t aSize)
     : mPtr(aData), mRemaining(aSize), mLength(aSize)
   {
   }
   template<size_t S>
-  explicit ByteReader(const AutoTArray<uint8_t, S>& aData)
+  explicit BufferReader(const AutoTArray<uint8_t, S>& aData)
     : mPtr(aData.Elements()), mRemaining(aData.Length()), mLength(aData.Length())
   {
   }
-  explicit ByteReader(const nsTArray<uint8_t>& aData)
+  explicit BufferReader(const nsTArray<uint8_t>& aData)
     : mPtr(aData.Elements()), mRemaining(aData.Length()), mLength(aData.Length())
   {
   }
-  explicit ByteReader(const mozilla::MediaByteBuffer* aData)
+  explicit BufferReader(const mozilla::MediaByteBuffer* aData)
     : mPtr(aData->Elements()), mRemaining(aData->Length()), mLength(aData->Length())
   {
   }
 
   void SetData(const nsTArray<uint8_t>& aData)
   {
     MOZ_ASSERT(!mPtr && !mRemaining);
     mPtr = aData.Elements();
     mRemaining = aData.Length();
     mLength = mRemaining;
   }
 
-  ~ByteReader()
+  ~BufferReader()
   {
   }
 
   size_t Offset() const
   {
     return mLength - mRemaining;
   }
 
--- a/media/libstagefright/moz.build
+++ b/media/libstagefright/moz.build
@@ -54,16 +54,17 @@ if CONFIG['OS_TARGET'] != 'Android':
     ]
 
 EXPORTS.mp4_demuxer += [
     'binding/include/mp4_demuxer/Adts.h',
     'binding/include/mp4_demuxer/AnnexB.h',
     'binding/include/mp4_demuxer/Atom.h',
     'binding/include/mp4_demuxer/AtomType.h',
     'binding/include/mp4_demuxer/BitReader.h',
+    'binding/include/mp4_demuxer/BufferReader.h',
     'binding/include/mp4_demuxer/BufferStream.h',
     'binding/include/mp4_demuxer/ByteReader.h',
     'binding/include/mp4_demuxer/ByteWriter.h',
     'binding/include/mp4_demuxer/DecoderData.h',
     'binding/include/mp4_demuxer/H264.h',
     'binding/include/mp4_demuxer/Index.h',
     'binding/include/mp4_demuxer/Interval.h',
     'binding/include/mp4_demuxer/MoofParser.h',