Bug 1407326 - remove references to invertIconForLightTheme in extensions codebase;r=rpl draft
authorJulian Descottes <jdescottes@mozilla.com>
Tue, 10 Oct 2017 19:49:04 +0200
changeset 677744 4435d53e0f96a2beea27d5e727642479fba7d1f2
parent 677741 d1a9416336dc53e05890c11e95a73c77e8450696
child 735210 4104f6028158ec8bb22a715b4cf108587fcb2d9c
push id83794
push userjdescottes@mozilla.com
push dateTue, 10 Oct 2017 17:49:37 +0000
reviewersrpl
bugs1407326
milestone58.0a1
Bug 1407326 - remove references to invertIconForLightTheme in extensions codebase;r=rpl MozReview-Commit-ID: B2eTpm6qbOh
browser/components/extensions/ext-devtools-panels.js
browser/components/extensions/test/browser/browser_ext_devtools_panel.js
--- a/browser/components/extensions/ext-devtools-panels.js
+++ b/browser/components/extensions/ext-devtools-panels.js
@@ -83,17 +83,16 @@ class ParentDevToolsPanel {
     const extensionName = this.context.extension.name;
 
     this.toolbox.addAdditionalTool({
       id: this.id,
       url: "about:blank",
       icon: icon,
       label: title,
       tooltip: `DevTools Panel added by "${extensionName}" add-on.`,
-      invertIconForLightTheme: false,
       visibilityswitch:  `devtools.webext-${this.id}.enabled`,
       isTargetSupported: target => target.isLocalTab,
       build: (window, toolbox) => {
         if (toolbox !== this.toolbox) {
           throw new Error("Unexpected toolbox received on addAdditionalTool build property");
         }
 
         const destroy = this.buildPanel(window);
--- a/browser/components/extensions/test/browser/browser_ext_devtools_panel.js
+++ b/browser/components/extensions/test/browser/browser_ext_devtools_panel.js
@@ -209,19 +209,16 @@ add_task(async function test_devtools_pa
   is(toolboxAdditionalTools.length, 1,
      "Got the expected number of toolbox specific panel registered.");
 
   await testThemeSwitching(extension);
 
   const panelDef = toolboxAdditionalTools[0];
   const panelId = panelDef.id;
 
-  is(panelDef.invertIconForLightTheme, false,
-     "devtools.panel.create set invertIconForLightTheme to false by default");
-
   await gDevTools.showToolbox(target, panelId);
   const {devtoolsPageTabId} = await extension.awaitMessage("devtools_panel_shown");
   const devtoolsPanelTabId = await extension.awaitMessage("devtools_panel_inspectedWindow_tabId");
   is(devtoolsPanelTabId, devtoolsPageTabId,
      "Got the same devtools.inspectedWindow.tabId from devtools page and panel");
   is(await extension.awaitMessage("initial_theme_panel"),
     "light",
     "The initial theme is reported as expected from a devtools panel.");