Bug 1399116 - browser_google_*codes.js don't need to show the search bar in their tests. Remove showing it to help avoid intermittents. draft
authorMark Banner <standard8@mozilla.com>
Mon, 09 Oct 2017 14:20:50 +0100
changeset 676719 0988b7c62f901ff290da27185a70d968b0096bbf
parent 676640 d54bb49a08e9d1bdab303bc901062092159927c7
child 735036 14a216a1cc7e8cff966ab45be6e5e34e218ea076
push id83603
push userbmo:standard8@mozilla.com
push dateMon, 09 Oct 2017 13:21:03 +0000
bugs1399116
milestone58.0a1
Bug 1399116 - browser_google_*codes.js don't need to show the search bar in their tests. Remove showing it to help avoid intermittents. MozReview-Commit-ID: 2ovv1ckOvwb
browser/components/search/test/browser_google_codes.js
browser/components/search/test/browser_google_nocodes.js
--- a/browser/components/search/test/browser_google_codes.js
+++ b/browser/components/search/test/browser_google_codes.js
@@ -115,22 +115,16 @@ add_task(async function preparation() {
     waitForSearchNotification("write-cache-to-disk-complete", resolve);
   });
 });
 
 add_task(async function tests() {
   let engine = Services.search.getEngineByName("Google");
   ok(engine, "Google");
 
-  // Show the search bar after initializing the search service, to avoid the
-  // synchronous initialization to interfere.
-  await SpecialPowers.pushPrefEnv({ set: [
-    ["browser.search.widget.inNavBar", true],
-  ]});
-
   let base = "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&client=firefox-b";
 
   // Keyword uses a slightly different code
   let keywordBase = base + "-ab";
 
   let url;
 
   // Test search URLs (including purposes).
--- a/browser/components/search/test/browser_google_nocodes.js
+++ b/browser/components/search/test/browser_google_nocodes.js
@@ -115,22 +115,16 @@ add_task(async function preparation() {
     waitForSearchNotification("write-cache-to-disk-complete", resolve);
   });
 });
 
 add_task(async function tests() {
   let engine = Services.search.getEngineByName("Google");
   ok(engine, "Google");
 
-  // Show the search bar after initializing the search service, to avoid the
-  // synchronous initialization to interfere.
-  await SpecialPowers.pushPrefEnv({ set: [
-    ["browser.search.widget.inNavBar", true],
-  ]});
-
   let base = "https://www.google.com/search?q=foo&ie=utf-8&oe=utf-8";
 
   let url;
 
   // Test search URLs (including purposes).
   url = engine.getSubmission("foo", null, "contextmenu").uri.spec;
   is(url, base, "Check context menu search URL for 'foo'");
   url = engine.getSubmission("foo", null, "keyword").uri.spec;