Bug 1406787 - Click on currently active ping in start section should open ping picker. r?Dexter
MozReview-Commit-ID: 1riOrN2Oj1P
--- a/toolkit/content/aboutTelemetry.js
+++ b/toolkit/content/aboutTelemetry.js
@@ -337,19 +337,20 @@ var PingPicker = {
let pingNameHtml = "<span class=\"change-ping\">" + pingName + "</span>";
explanation = bundle.formatStringFromName("pingDetailsCurrent", [pingLink, pingNameHtml], 2);
}
let pingExplanation = document.getElementById("ping-explanation");
// eslint-disable-next-line no-unsanitized/property
pingExplanation.innerHTML = explanation;
- pingExplanation.querySelector(".change-ping").addEventListener("click", () =>
- document.getElementById("ping-picker").classList.remove("hidden")
- );
+ pingExplanation.querySelector(".change-ping").addEventListener("click", (ev) => {
+ document.getElementById("ping-picker").classList.remove("hidden");
+ ev.stopPropagation();
+ });
GenericSubsection.deleteAllSubSections();
},
async update() {
let viewCurrent = document.getElementById("ping-source-current").checked;
let currentChanged = viewCurrent !== this.viewCurrentPingData;
this.viewCurrentPingData = viewCurrent;