Bug 1406787 - Click on currently active ping in start section should open ping picker. r?Dexter draft
authorSebastian Hengst <archaeopteryx@coole-files.de>
Sun, 08 Oct 2017 21:41:00 +0200
changeset 676555 34bd8d1b79b71d21637efba37825b6a8f9f622ab
parent 676552 5eba13f5b3a6ad80decdd8c7b30bff5fa477844f
child 734966 d1eb28701f8b73b7ec595ca7d75a0c2a8e1c841f
push id83525
push userarchaeopteryx@coole-files.de
push dateSun, 08 Oct 2017 19:41:36 +0000
reviewersDexter
bugs1406787
milestone58.0a1
Bug 1406787 - Click on currently active ping in start section should open ping picker. r?Dexter MozReview-Commit-ID: 1riOrN2Oj1P
toolkit/content/aboutTelemetry.js
--- a/toolkit/content/aboutTelemetry.js
+++ b/toolkit/content/aboutTelemetry.js
@@ -337,19 +337,20 @@ var PingPicker = {
       let pingNameHtml = "<span class=\"change-ping\">" + pingName + "</span>";
       explanation = bundle.formatStringFromName("pingDetailsCurrent", [pingLink, pingNameHtml], 2);
     }
 
     let pingExplanation = document.getElementById("ping-explanation");
 
     // eslint-disable-next-line no-unsanitized/property
     pingExplanation.innerHTML = explanation;
-    pingExplanation.querySelector(".change-ping").addEventListener("click", () =>
-      document.getElementById("ping-picker").classList.remove("hidden")
-    );
+    pingExplanation.querySelector(".change-ping").addEventListener("click", (ev) => {
+      document.getElementById("ping-picker").classList.remove("hidden");
+      ev.stopPropagation();
+    });
 
     GenericSubsection.deleteAllSubSections();
   },
 
   async update() {
     let viewCurrent = document.getElementById("ping-source-current").checked;
     let currentChanged = viewCurrent !== this.viewCurrentPingData;
     this.viewCurrentPingData = viewCurrent;