Bug 1405643 - ensure items don't spill out of the panel on small window sizes in customize mode, r?mikedeboer draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Wed, 04 Oct 2017 15:47:28 +0100
changeset 674924 545a693561cd23eced91e4b3de45fb33bbf6c8fe
parent 674765 294f332a35538940469b1a2576615ff5ffe1e016
child 674925 50862761342c84e2151a72f2d0dc1315c765930b
push id82974
push usergijskruitbosch@gmail.com
push dateWed, 04 Oct 2017 15:08:34 +0000
reviewersmikedeboer
bugs1405643
milestone58.0a1
Bug 1405643 - ensure items don't spill out of the panel on small window sizes in customize mode, r?mikedeboer MozReview-Commit-ID: 6GCSSLzt7h1
browser/base/content/browser.css
browser/themes/shared/customizableui/customizeMode.inc.css
--- a/browser/base/content/browser.css
+++ b/browser/base/content/browser.css
@@ -1245,29 +1245,29 @@ toolbarpaletteitem[place="palette"] > #d
 }
 
 #customization-panelHolder {
   padding-top: 10px;
   padding-bottom: 10px;
 }
 
 #customization-panelHolder > #widget-overflow-fixed-list {
-  flex: 0 1 auto; /* Size to content, but allow ourselves to shrink */
+  flex: 1 1 auto; /* Grow within the available space, and allow ourselves to shrink */
   display: flex;
   flex-direction: column;
   overflow-y: auto;
   overflow-x: hidden;
 }
 
 #customization-panelWrapper,
 #customization-panelWrapper > .panel-arrowcontent,
 #customization-panelHolder {
   flex-direction: column;
   display: flex;
-  min-height: 0;
+  min-height: calc(174px + 8em);
 }
 
 #customization-panelWrapper {
   flex: 1 1 auto;
   height: 0; /* Don't let my contents affect ancestors' content-based sizing */
   align-items: end; /* align to the end on the cross-axis (affects arrow) */
 }
 
--- a/browser/themes/shared/customizableui/customizeMode.inc.css
+++ b/browser/themes/shared/customizableui/customizeMode.inc.css
@@ -506,17 +506,16 @@ toolbarpaletteitem[place=toolbar] > tool
   font-size: 1.3em;
   font-weight: 500;
   padding: 2px 12px;
   margin: 0;
 }
 
 #customization-panelHolder > #widget-overflow-fixed-list {
   padding-top: 10px;
-  min-height: 225px;
 }
 
 /**
  * We create a ::before pseudoelement that contains a background image to show the
  * drop dragon. This element fades in and out depending on whether the containing
  * panel list is empty and unhovered, or not.
  */
 #customization-panelHolder > #widget-overflow-fixed-list:not(:empty) {