Bug 1404263 - update the bookmarks toolbar item in the bookmarking tools subview when it is shown, r?mikedeboer
MozReview-Commit-ID: 1zesvAmYkAM
--- a/browser/base/content/browser-places.js
+++ b/browser/base/content/browser-places.js
@@ -1895,16 +1895,29 @@ var BookmarkingUI = {
switch (button.id) {
case "panelMenu_toggleBookmarksMenu":
let placement = CustomizableUI.getPlacementOfWidget(this.BOOKMARK_BUTTON_ID);
button.setAttribute("checked", !!placement && placement.area == CustomizableUI.AREA_NAVBAR);
break;
case "panelMenu_viewBookmarksSidebar":
button.setAttribute("checked", SidebarUI.currentID == "viewBookmarksSidebar");
break;
+ case "panelMenu_viewBookmarksToolbar":
+ let toolbar = document.getElementById("PersonalToolbar");
+ // This is an actual toolbarbutton[type=checkbox], and its checked
+ // attribute will get added/removed by the binding when clicked.
+ // Setting the attribute to 'false' breaks showing the toolbar,
+ // because the binding removes the attribute instead of setting it
+ // to 'true' when clicked.
+ if (toolbar.getAttribute("collapsed") != "true") {
+ button.setAttribute("checked", "true");
+ } else {
+ button.removeAttribute("checked");
+ }
+ break;
default:
update = false;
break;
}
if (update) {
updateToggleControlLabel(button);
}
}