Bug 1405552 - Do not expose FileReaderSync to serviceworkers, to match the spec; r=baku draft
authorThomas Wisniewski <wisniewskit@gmail.com>
Fri, 04 May 2018 09:28:13 -0400
changeset 791513 04612e6e73952619f800e7498a287848f6405b79
parent 791409 8994f35fe5fc89f4e8f4e09579a6962f8a4a3e65
push id108829
push userwisniewskit@gmail.com
push dateFri, 04 May 2018 14:40:23 +0000
reviewersbaku
bugs1405552
milestone61.0a1
Bug 1405552 - Do not expose FileReaderSync to serviceworkers, to match the spec; r=baku MozReview-Commit-ID: 1EJbrt8TXiq
dom/serviceworkers/test/test_serviceworker_interfaces.js
dom/webidl/FileReaderSync.webidl
testing/web-platform/meta/FileAPI/historical.https.html.ini
--- a/dom/serviceworkers/test/test_serviceworker_interfaces.js
+++ b/dom/serviceworkers/test/test_serviceworker_interfaces.js
@@ -124,18 +124,16 @@ var interfaceNamesInGlobalScope =
     "FetchEvent",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "File",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "FileList",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "FileReader",
 // IMPORTANT: Do not change this list without review from a DOM peer!
-    "FileReaderSync",
-// IMPORTANT: Do not change this list without review from a DOM peer!
     "FormData",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "Headers",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "IDBCursor",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "IDBCursorWithValue",
 // IMPORTANT: Do not change this list without review from a DOM peer!
--- a/dom/webidl/FileReaderSync.webidl
+++ b/dom/webidl/FileReaderSync.webidl
@@ -6,17 +6,17 @@
  * The origin of this IDL file is
  * http://dev.w3.org/2006/webapi/FileAPI/
  *
  * Copyright © 2012 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
  * liability, trademark and document use rules apply.
  */
 
 [Constructor,
- Exposed=Worker]
+ Exposed=(DedicatedWorker,SharedWorker)]
 interface FileReaderSync {
 
   // Synchronously return strings
 
   [Throws]
   ArrayBuffer readAsArrayBuffer(Blob blob);
   [Throws]
   DOMString readAsBinaryString(Blob blob);
deleted file mode 100644
--- a/testing/web-platform/meta/FileAPI/historical.https.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[historical.https.html]
-  ["FileReaderSync" should not be supported in service workers]
-    expected: FAIL
-