Bug 1405377 - remove trailing separator in recently closed tabs/windows subviews, r?mikedeboer draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Tue, 03 Oct 2017 19:29:36 +0100
changeset 674398 b0e2a00b3bdb5494b1707ae6e90a6e87537279f3
parent 673986 65dac33a5682f3ec5a675e7f3314b0c1520a13fa
child 734317 19e15deb075ce0204b37d58f0e6608a03c10af22
push id82823
push usergijskruitbosch@gmail.com
push dateTue, 03 Oct 2017 18:32:54 +0000
reviewersmikedeboer
bugs1405377
milestone58.0a1
Bug 1405377 - remove trailing separator in recently closed tabs/windows subviews, r?mikedeboer The third param of 'getTabsFragment' and 'getWindowsFragment' toggles whether the 'restore all' item gets prefixed (true) or suffixed (false). The prefixed version doesn't get a separator, so this seems like the simplest fix. MozReview-Commit-ID: BzKWvndWUMp
browser/components/customizableui/CustomizableWidgets.jsm
--- a/browser/components/customizableui/CustomizableWidgets.jsm
+++ b/browser/components/customizableui/CustomizableWidgets.jsm
@@ -210,17 +210,17 @@ const CustomizableWidgets = [
       let document = event.target.ownerDocument;
       let window = document.defaultView;
       let viewType = panelview.id == this.recentlyClosedTabsPanel ? "Tabs" : "Windows";
 
       this._panelMenuView.clearAllContents(panelview);
 
       let utils = RecentlyClosedTabsAndWindowsMenuUtils;
       let method = `get${viewType}Fragment`;
-      let fragment = utils[method](window, "toolbarbutton");
+      let fragment = utils[method](window, "toolbarbutton", true);
       let elementCount = fragment.childElementCount;
       this._panelMenuView._setEmptyPopupStatus(panelview, !elementCount);
       if (!elementCount)
         return;
 
       let body = document.createElement("vbox");
       body.className = "panel-subview-body";
       body.appendChild(fragment);