Bug 1403934 - Fix headless screenshot shutdown on MacOS. r?mossop draft
authorBrendan Dahl <brendan.dahl@gmail.com>
Mon, 02 Oct 2017 14:53:27 -0700
changeset 674338 d3f214d41357c29009c963d4e69d6ce6ca8da42f
parent 673759 15f221f491f707b1e8e46da344b6dd5a394b1242
child 734298 103ccafe992b4ca3c81a5b0a4d16da054a64ff3c
push id82801
push userbmo:bdahl@mozilla.com
push dateTue, 03 Oct 2017 16:27:12 +0000
reviewersmossop
bugs1403934
milestone58.0a1
Bug 1403934 - Fix headless screenshot shutdown on MacOS. r?mossop MacOS needs the hidden window to be closed to shutdown properly. MozReview-Commit-ID: 46M7q5pM35r
browser/components/shell/HeadlessShell.jsm
browser/components/shell/test/chrome.ini
--- a/browser/components/shell/HeadlessShell.jsm
+++ b/browser/components/shell/HeadlessShell.jsm
@@ -151,11 +151,12 @@ let HeadlessShell = {
 
       if (URLlist.length == 1) {
         await takeScreenshot(fullWidth, fullHeight, contentWidth, contentHeight, path, URLlist[0]);
       } else {
         dump("expected exactly one URL when using `screenshot`\n");
       }
     } finally {
       Services.startup.exitLastWindowClosingSurvivalArea();
+      Services.startup.quit(Ci.nsIAppStartup.eForceQuit);
     }
   }
 };
--- a/browser/components/shell/test/chrome.ini
+++ b/browser/components/shell/test/chrome.ini
@@ -1,5 +1,5 @@
 [DEFAULT]
 support-files = headless.html
 
 [test_headless_screenshot.html]
-skip-if = (os != 'win' && os != 'linux')
+skip-if = toolkit == 'android'