Bug 1404057 - stylo: `all` shorthand should not apply to internal properties; r?xidorn draft
authorManish Goregaokar <manishearth@gmail.com>
Mon, 02 Oct 2017 18:53:19 -0700
changeset 674312 2232528f74742bd4b6352a5c3ef600f6240c5035
parent 674178 11fe0a2895aab26c57bcfe61b3041d7837e954cd
child 674313 2f7ad0a04862a58221ec1083eda224dd4a69abb3
push id82784
push userbmo:manishearth@gmail.com
push dateTue, 03 Oct 2017 15:33:26 +0000
reviewersxidorn
bugs1404057
milestone58.0a1
Bug 1404057 - stylo: `all` shorthand should not apply to internal properties; r?xidorn MozReview-Commit-ID: FENWGo3YqYE
servo/components/style/properties/properties.mako.rs
--- a/servo/components/style/properties/properties.mako.rs
+++ b/servo/components/style/properties/properties.mako.rs
@@ -170,17 +170,19 @@ pub mod shorthands {
     <%include file="/shorthand/padding.mako.rs" />
     <%include file="/shorthand/position.mako.rs" />
     <%include file="/shorthand/inherited_svg.mako.rs" />
     <%include file="/shorthand/text.mako.rs" />
 
     // We don't defined the 'all' shorthand using the regular helpers:shorthand
     // mechanism, since it causes some very large types to be generated.
     <% data.declare_shorthand("all",
-                              [p.name for p in data.longhands if p.name not in ['direction', 'unicode-bidi']],
+                              [p.name for p in data.longhands
+                                if p.name not in ['direction', 'unicode-bidi']
+                                      and not p.internal],
                               spec="https://drafts.csswg.org/css-cascade-3/#all-shorthand") %>
 }
 
 /// A module with all the code related to animated properties.
 ///
 /// This needs to be "included" by mako at least after all longhand modules,
 /// given they populate the global data.
 pub mod animated_properties {