Bug 1403690 Part 1: Adjust heap write analysis whitelist to include Gecko_GetLookAndFeelSystemColor. draft
authorBrad Werth <bwerth@mozilla.com>
Mon, 02 Oct 2017 15:00:33 -0700
changeset 687770 ab59b699887822640c3ebc61ecaca79ca7b658b8
parent 687660 ae49d4a5762264ded3aae4006baddc2203b79b94
child 687771 4027bb9d9fbc754218cbd9a706d93fbf37b0660f
push id86600
push userbwerth@mozilla.com
push dateFri, 27 Oct 2017 18:57:26 +0000
bugs1403690
milestone58.0a1
Bug 1403690 Part 1: Adjust heap write analysis whitelist to include Gecko_GetLookAndFeelSystemColor. MozReview-Commit-ID: 1PjN0ZTpw10
js/src/devtools/rootAnalysis/analyzeHeapWrites.js
--- a/js/src/devtools/rootAnalysis/analyzeHeapWrites.js
+++ b/js/src/devtools/rootAnalysis/analyzeHeapWrites.js
@@ -487,17 +487,17 @@ function ignoreContents(entry)
         "Gecko_NewCSSValueSharedList",
         "Gecko_CSSValue_InitSharedList",
 
         // Unable to trace through dataflow, but straightforward if inspected.
         "Gecko_NewNoneTransform",
 
         // Need main thread assertions or other fixes.
         /EffectCompositor::GetServoAnimationRule/,
-        /LookAndFeel::GetColor/,
+        /Gecko_GetLookAndFeelSystemColor/,
     ];
     if (entry.matches(whitelist))
         return true;
 
     if (entry.isSafeArgument(0)) {
         var heapWhitelist = [
             // Operations on heap structures pointed to by arrays and strings are
             // threadsafe as long as the array/string itself is threadsafe.