Bug 1403346 - Move cxxflags filtering for libfuzzer from Makefile.in to moz.build
MozReview-Commit-ID: LDHiMMRjqut
--- a/tools/fuzzing/libfuzzer/Makefile.in
+++ b/tools/fuzzing/libfuzzer/Makefile.in
@@ -2,11 +2,9 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
include $(topsrcdir)/config/rules.mk
# According to the LLVM docs, LibFuzzer isn't supposed to be built with any
# sanitizer flags and in fact, building it with ASan coverage currently causes
# Clang 3.9+ to crash, so we filter out all sanitizer-related flags here.
-CXXFLAGS := $(filter-out -fsanitize%,$(CXXFLAGS))
-CFLAGS := $(filter-out -fsanitize%,$(CFLAGS))
LDFLAGS := $(filter-out -fsanitize%,$(LDFLAGS))
--- a/tools/fuzzing/libfuzzer/moz.build
+++ b/tools/fuzzing/libfuzzer/moz.build
@@ -33,8 +33,17 @@ SOURCES += [
'FuzzerUtilDarwin.cpp',
'FuzzerUtilLinux.cpp',
'FuzzerUtilPosix.cpp',
'FuzzerUtilWindows.cpp'
]
if CONFIG['CLANG_CXX']:
CXXFLAGS += ['-Wno-unreachable-code-return']
+
+# According to the LLVM docs, LibFuzzer isn't supposed to be built with any
+# sanitizer flags and in fact, building it with ASan coverage currently causes
+# Clang 3.9+ to crash, so we filter out all sanitizer-related flags here.
+for flags_var in ('OS_CFLAGS', 'OS_CXXFLAGS'):
+ COMPILE_FLAGS[flags_var] = [
+ f for f in COMPILE_FLAGS.get(flags_var, [])
+ if not f.startswith('-fsanitize')
+ ]