Bug 1389721 - fix page action menu to deal with not being passed an event, so the 'save link to pocket' context menu works, r?jaws draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Mon, 02 Oct 2017 20:34:01 +0100
changeset 674187 80c8c5cbeabdde42f8f5fb1151a0627c3f63a173
parent 673986 65dac33a5682f3ec5a675e7f3314b0c1520a13fa
child 734249 0f93c9a9fa8accc1b65137517053c7429910b08b
push id82748
push usergijskruitbosch@gmail.com
push dateTue, 03 Oct 2017 10:45:31 +0000
reviewersjaws
bugs1389721
milestone58.0a1
Bug 1389721 - fix page action menu to deal with not being passed an event, so the 'save link to pocket' context menu works, r?jaws This also removes the now-obsolete onBeforeCommand method from the pocket code. MozReview-Commit-ID: EjrMoAIv3xw
browser/base/content/browser-pageActions.js
browser/extensions/pocket/content/Pocket.jsm
--- a/browser/base/content/browser-pageActions.js
+++ b/browser/base/content/browser-pageActions.js
@@ -456,17 +456,17 @@ var BrowserPageActions = {
     let id = this._panelButtonNodeIDForActionID(action.id);
     let node = document.getElementById(id);
     if (node) {
       node.setAttribute("label", action.title);
     }
   },
 
   doCommandForAction(action, event, buttonNode) {
-    if (event.type == "click" && event.button != 0) {
+    if (event && event.type == "click" && event.button != 0) {
       return;
     }
     PageActions.logTelemetry("used", action, buttonNode);
     // If we're in the panel, open a subview inside the panel:
     // Note that we can't use this.panelNode.contains(buttonNode) here
     // because of XBL boundaries breaking ELement.contains.
     if (action.subview && buttonNode && buttonNode.closest("panel") == this.panelNode) {
       let panelViewNodeID = this._panelViewNodeIDForActionID(action.id, false);
--- a/browser/extensions/pocket/content/Pocket.jsm
+++ b/browser/extensions/pocket/content/Pocket.jsm
@@ -27,20 +27,16 @@ var Pocket = {
       where = "tab";
     }
     win.openUILinkIn(this.listURL, where);
   },
 
   /**
    * Functions related to the Pocket panel UI.
    */
-  onBeforeCommand(event) {
-    BrowserUtils.setToolbarButtonHeightProperty(event.target);
-  },
-
   onShownInPhotonPageActionPanel(panel, iframe) {
     let window = panel.ownerGlobal;
     window.pktUI.setPhotonPageActionPanelFrame(iframe);
     Pocket._initPanelView(window);
   },
 
   onPanelViewShowing(event) {
     Pocket._initPanelView(event.target.ownerGlobal);