Bug 1400831 - Use a shorter tab-drop-indicator image to fit both default and compact themes, and move its box-align to CSS. r?Dao draft
authorSam Foster <sfoster@mozilla.com>
Mon, 02 Oct 2017 11:01:21 -0700
changeset 675717 1785d886e42b627e96a7b2b7611ff75b9150216f
parent 675508 53bbdaaa2b8c1819061be26101b075c081b23260
child 734687 787b357bd4a930520b17f0a8c6dd91972fd96c4b
push id83218
push userbmo:sfoster@mozilla.com
push dateThu, 05 Oct 2017 19:23:49 +0000
reviewersDao
bugs1400831
milestone58.0a1
Bug 1400831 - Use a shorter tab-drop-indicator image to fit both default and compact themes, and move its box-align to CSS. r?Dao * Fix shadow overlap and re-optimize w. pngcrush and optipng w. -strip all to remove metadata MozReview-Commit-ID: GJJfYMUz34q
browser/base/content/tabbrowser.css
browser/base/content/tabbrowser.xml
browser/themes/osx/browser.css
browser/themes/osx/tabbrowser/tabDragIndicator.png
browser/themes/osx/tabbrowser/tabDragIndicator@2x.png
--- a/browser/base/content/tabbrowser.css
+++ b/browser/base/content/tabbrowser.css
@@ -58,16 +58,20 @@
   direction: rtl;
   mask-image: linear-gradient(to right, transparent, black 2em);
 }
 
 tabpanels {
   background-color: transparent;
 }
 
+.tab-drop-indicator-box {
+  -moz-box-align: end;
+}
+
 .tab-drop-indicator {
   position: relative;
   z-index: 2;
 }
 
 /* Apply crisp rendering for favicons at exactly 2dppx resolution */
 @media (resolution: 2dppx) {
   .tab-icon-image {
--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@@ -6329,17 +6329,17 @@
 
   <binding id="tabbrowser-tabs"
            extends="chrome://global/content/bindings/tabbox.xml#tabs">
     <resources>
       <stylesheet src="chrome://browser/content/tabbrowser.css"/>
     </resources>
 
     <content>
-      <xul:hbox align="end">
+      <xul:hbox class="tab-drop-indicator-box">
         <xul:image class="tab-drop-indicator" anonid="tab-drop-indicator" collapsed="true"/>
       </xul:hbox>
       <xul:arrowscrollbox anonid="arrowscrollbox" orient="horizontal" flex="1"
                           style="min-width: 1px;"
                           class="tabbrowser-arrowscrollbox">
 <!--
  This is a hack to circumvent bug 472020, otherwise the tabs show up on the
  right of the newtab button.
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -822,16 +822,20 @@ html|span.ac-emphasize-text-url {
 #tabbrowser-tabs {
   -moz-box-align: stretch;
 }
 
 /**
  * Tab Drag and Drop
  */
 
+.tab-drop-indicator-box {
+  -moz-box-align: center;
+}
+
 .tab-drop-indicator {
   list-style-image: url(chrome://browser/skin/tabbrowser/tabDragIndicator.png);
   margin-top: -2px;
   z-index: 3;
 }
 
 @media (min-resolution: 2dppx) {
   .tab-drop-indicator {
index a373cae538b323666b9a0a363077c00f73c1a0f6..e53d6bcf0af6d843f5aeb9049d238319e9cc8f01
GIT binary patch
literal 416
zc$@*C0bl-!P)<h;3K|Lk000e1NJLTq000aC0012b1^@s6p8t*60004JNkl<ZILqyn
zJxjw-6o!Ko2UklsONZ{dIaut^a1ccb)wxg*6hVu05l08Xq7cx{SzSU0MF%ILLo{@V
zgI}RTV@Q)|%p>>KQets%?12{!?>W!SIr&nQpBT|~ecHC|9pCp)5jh?;r7seuX%?TX
z;HrA$JQu6Bi^%b)(bGM-Ua!v@kHPg)#rEdb+hMQp?#<vv)3ltt(wJpgwe3Uag@)C=
z_txFR$1NhqtJIv=C=TcaNOd}$v&Ajjr})<TybQxoL*#f1o9%!edI2U}*FBd2GfRM6
z0-onx(EANEo6Qq0OL1f0u{ar#%aIJjIF>-FTrRJ$*r26LrP8t-iAAPVRo!I-xjZ7r
zqZai{%B8tg$w)JWLSc>BB|wfxEz)@J155}g*AL){TB84HLuX@vY}~6MBNGE;lmRgW
zhQPl9e46MlK)TUrsPZR3jyDM4L&-;)7s?Co*BBKIX`!U>y72{(AoHSQW2sL70000<
KMNUMnLSTY+&%F--
index b51b873cbd928ba222d9244eaf5c06562d699427..4d17c445483c5be9f2cd4f0f3ddf415895a47041
GIT binary patch
literal 1183
zc$@*B1YrA#P)<h;3K|Lk000e1NJLTq000;O0024&1^@s6suP*T000DLNkl<ZSi{v=
z-%nF#7;a^Q_MFqx3N2V+PB9@%wk#$iS=J){1xwi2cCmY7mTZZMWXs%)sAb}yRCJ5C
zKp`5YW=_44Eb~W9FezRth21V$_+^WQ0+xJxpL5RFp0BpZap$IQ@+7C<`@YZf{XXZd
z!%^OxgepQ!AP`V|WU8vxdcEGAWL~tvXT&%i7R(^tEqOd1zsu*_t0>C5lH~ost*Rda
zct)Gc<$D`3h~2Ib0;<tVm)G0e+|trEHg>r;nM^*+WHNJ`o0~7lvgvgCAGF2e@m|Cr
z7CFe>N(7D?>RCXR<@bk%h9b+$%m1=h7-EKphkKBNTw~gtC3{W*^}*m<t&@|JH#k9Z
zk+G8x7;7J6Z0{u<hsN|a__!elx!@=@k}3=lz2M{<ImV9PW32I4#)7|;27KTC#aQ-5
zK?EGebXA#pzgwcl{Uf8JXF2&7H_8(i<MZG392hvjWh}fliYn}ceJw2qGb=0FpufLM
zi5IQm_+4FKWo2~{T>9?PM^S^Vc;(7?6amvD(MY}8b+Ld@oUz+~(}J$+z%$y+G02%V
z)?|GAY80H>g5$toPtVTIK7#YaeK9dS%2;~s<=ule_{_1$g@KDW-_s5wPACozZ8uH7
zttbh-EobnVW07lY-9_ST1-ApoAEz^y%V~R|iFQWAg#s`o<t(!y#v&I+Tsd%p+kq{G
zA8TuC>;G4v`BDi1K1FkLb4zfB<6_dSEv5)Qb8NdYMN3Od>HHM&MNTB9rs4dN4p;qP
z0pStGQY97{ZSa|6f4Han5{X1IzsP)>#$vH?IG--izP=zPhDP+>K3~^?=TH$ja*zuf
zh{b-(Z&QBIg2AT4sZ?qi0XY7FL2E#cHnLRec~jG#!{&qLH17UTB+_#gLF;tvJFipX
z`R(D;YkCe09K;niUln{5b&{eS`QzrzM_lAP>Q%#Fd1Cmw{w!Q}$OQ+u%$HsMy2edd
z>-Qg<n3$O2i-~!~J>x$w0&Pzg3X6W{&ctKnf}`AvM|<J8J)SnVqJGoeefrw`{QNUc
z;E##mhL}^QPG3h3a?8DNibX<{@O6Ftu6|Bb7Zbq^F^F|*^S(8?@Y1KD9*||vvAn>5
z2yPV9g;>j97uaTmgPf>#Km<3$7+cbs83N&L2!w4B*cla3c>=zE5w;6>`$gC<&?mxn
z0kuy=<q3Fx7EyTu$~h60Cm{EVs5}9wSA^{X?z18)Pr&t)h{_YF=@C(R0@Xbt>=%fL
zuwCHIhzR=y&WNyG;EgjPY!`5Li?BnWj=q>bdX)fTjDo|O8RczjHk;Kd<sf|vIl6W5
zk9w-DH}d7GRYM6%J$r}B+ZpX|gBhK;F{(f7<?7T7VtBb~)v6^)3Vzbr*|)m7`ckEg
zHuw-@luVXw2YN>3=f@o#9nnPMaT0$w0C+|ld`9ngI9}6G=`_f)`XyD5U%6%VD1c|Q
x!B<>OzSc<ar-n;W+TDus8GvW)kB)8h{6GJd_45u@!eamc002ovPDHLkV1kt-MVkNs