Bug 1005755 - Update Net logging in the Console; r=nchevobbe draft
authorJan Odvarko <odvarko@gmail.com>
Mon, 16 Oct 2017 15:13:03 +0200
changeset 680830 2ef0ba75c4dfe95f76ab52532ebc01cab9be7a30
parent 680829 e5bf4ae910ccd0a7d50c83d297a5852373fd5559
child 680831 f434b3d8cc583bebec567e195d4d23711b01ea4e
push id84648
push userjodvarko@mozilla.com
push dateMon, 16 Oct 2017 13:14:27 +0000
reviewersnchevobbe
bugs1005755
milestone58.0a1
Bug 1005755 - Update Net logging in the Console; r=nchevobbe MozReview-Commit-ID: 6lLjifqV2sQ
devtools/client/webconsole/new-console-output/components/message-types/NetworkEventMessage.js
--- a/devtools/client/webconsole/new-console-output/components/message-types/NetworkEventMessage.js
+++ b/devtools/client/webconsole/new-console-output/components/message-types/NetworkEventMessage.js
@@ -87,28 +87,45 @@ function NetworkEventMessage({
     }
   };
 
   // Message body components.
   const method = dom.span({className: "method" }, request.method);
   const xhr = isXHR
     ? dom.span({ className: "xhr" }, l10n.getStr("webConsoleXhrIndicator"))
     : null;
-  const url = dom.a({ className: "url", title: request.url, onClick: toggle },
+  const requestUrl = dom.a({ className: "url", title: request.url, onClick: toggle },
     request.url.replace(/\?.+/, ""));
   const statusBody = statusInfo
     ? dom.a({ className: "status", onClick: toggle }, statusInfo)
     : null;
 
-  const messageBody = [method, xhr, url, statusBody];
+  const messageBody = [method, xhr, requestUrl, statusBody];
+
+  // API consumed by Net monitor UI components. Most of the method
+  // are not needed in context of the Console panel (atm) and thus
+  // let's just provide empty implementation.
+  // Individual methods might be implemented step by step as needed.
+  let connector = {
+    viewSourceInDebugger: (url, line) => {
+      serviceContainer.onViewSourceInDebugger({url, line});
+    },
+    getLongString: () => {},
+    getTabTarget: () => {},
+    getNetworkRequest: () => {},
+    sendHTTPRequest: () => {},
+    setPreferences: () => {},
+    triggerActivity: () => {},
+  };
 
   // Only render the attachment if the network-event is
   // actually opened (performance optimization).
   const attachment = open && dom.div({className: "network-info devtools-monospace"},
     TabboxPanel({
+      connector,
       activeTabId: networkMessageActiveTabId,
       request: networkMessageUpdate,
       sourceMapService: serviceContainer.sourceMapService,
       openLink: serviceContainer.openLink,
       selectTab: (tabId) => {
         dispatch(actions.selectNetworkMessageTab(tabId));
       },
     })