Bug 1404246 - Fix disabled scroll buttons in the tabs toolbar on Windows properly. r=dao draft
authorJohann Hofmann <jhofmann@mozilla.com>
Fri, 29 Sep 2017 12:03:00 +0200
changeset 672483 0e29d3d4f74daf383c72dd96ea828092457dcf2c
parent 672296 e6c32278f32cd5f7d159627b2157396b62d0c4a9
child 733822 fce1a06797844bba8cdc0e6ed688de4d19c8ba94
push id82267
push userbmo:jhofmann@mozilla.com
push dateFri, 29 Sep 2017 10:03:41 +0000
reviewersdao
bugs1404246
milestone58.0a1
Bug 1404246 - Fix disabled scroll buttons in the tabs toolbar on Windows properly. r=dao MozReview-Commit-ID: AjBDcRXjoFt
browser/themes/shared/tabs.inc.css
browser/themes/windows/browser.css
browser/themes/windows/compacttheme.css
--- a/browser/themes/shared/tabs.inc.css
+++ b/browser/themes/shared/tabs.inc.css
@@ -581,16 +581,17 @@ tabbrowser {
 /* Tab bar scroll arrows */
 
 .tabbrowser-arrowscrollbox > .scrollbutton-up,
 .tabbrowser-arrowscrollbox > .scrollbutton-down {
   list-style-image: url(chrome://browser/skin/arrow-left.svg);
   -moz-context-properties: fill, fill-opacity;
   fill: currentColor;
   fill-opacity: var(--toolbarbutton-icon-fill-opacity);
+  color: inherit;
 }
 
 .tabbrowser-arrowscrollbox > .scrollbutton-up:-moz-locale-dir(rtl),
 .tabbrowser-arrowscrollbox > .scrollbutton-down:-moz-locale-dir(ltr) {
   transform: scaleX(-1);
 }
 
 /* New tab button */
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -110,18 +110,17 @@
  * instead of in the tabs toolbar.
  */
 @media (-moz-os-version: windows-win7) {
   @media (-moz-windows-default-theme) {
     :root:not(:-moz-lwtheme) {
       --tabs-border: #4A4A4F;
     }
 
-    #TabsToolbar:not(:-moz-lwtheme),
-    #TabsToolbar:not(:-moz-lwtheme) toolbarbutton[disabled="true"] {
+    #TabsToolbar:not(:-moz-lwtheme) {
       color: hsl(240,9%,98%);
     }
 
     /* Always show full-height tab separators on tabs with borders. */
     .tabbrowser-tab:not(:-moz-lwtheme)::before {
       border-image: none !important;
     }
 
--- a/browser/themes/windows/compacttheme.css
+++ b/browser/themes/windows/compacttheme.css
@@ -22,18 +22,17 @@
 
 #toolbar-menubar {
   text-shadow: none !important;
 }
 
 @media (-moz-os-version: windows-win7) {
   @media (-moz-windows-default-theme) {
     /* Always show light toolbar elements on aero surface. */
-    #TabsToolbar,
-    #TabsToolbar toolbarbutton[disabled="true"] {
+    #TabsToolbar {
       color: hsl(240,9%,98%);
     }
 
     /* Keep showing the correct color inside the tabs. */
     .tabbrowser-tab {
       color: var(--chrome-color) !important;
     }
   }