Bug 1404147 Fixed Unsigned/Signed comparison in WindowsGamepad.cpp r?qdot
MozReview-Commit-ID: 8qjkVdk6zWT
--- a/dom/gamepad/windows/WindowsGamepad.cpp
+++ b/dom/gamepad/windows/WindowsGamepad.cpp
@@ -383,17 +383,17 @@ class WindowsGamepadService
static void DevicesChangeCallback(nsITimer *aTimer, void* aService);
private:
void ScanForDevices();
// Look for connected raw input devices.
void ScanForRawInputDevices();
// Look for connected XInput devices.
bool ScanForXInputDevices();
- bool HaveXInputGamepad(int userIndex);
+ bool HaveXInputGamepad(unsigned int userIndex);
bool mIsXInputMonitoring;
void PollXInput();
void CheckXInputChanges(Gamepad& gamepad, XINPUT_STATE& state);
// Get information about a raw input gamepad.
bool GetRawGamepad(HANDLE handle);
void Cleanup();
@@ -457,17 +457,17 @@ void
WindowsGamepadService::DevicesChangeCallback(nsITimer *aTimer, void* aService)
{
MOZ_ASSERT(aService);
WindowsGamepadService* self = static_cast<WindowsGamepadService*>(aService);
self->DevicesChanged(false);
}
bool
-WindowsGamepadService::HaveXInputGamepad(int userIndex)
+WindowsGamepadService::HaveXInputGamepad(unsigned int userIndex)
{
for (unsigned int i = 0; i < mGamepads.Length(); i++) {
if (mGamepads[i].type == kXInputGamepad
&& mGamepads[i].userIndex == userIndex) {
mGamepads[i].present = true;
return true;
}
}
@@ -481,17 +481,17 @@ WindowsGamepadService::ScanForXInputDevi
bool found = false;
RefPtr<GamepadPlatformService> service =
GamepadPlatformService::GetParentService();
if (!service) {
return found;
}
- for (int i = 0; i < XUSER_MAX_COUNT; i++) {
+ for (unsigned int i = 0; i < XUSER_MAX_COUNT; i++) {
XINPUT_STATE state = {};
if (mXInput.mXInputGetState(i, &state) != ERROR_SUCCESS) {
continue;
}
found = true;
// See if this device is already present in our list.
if (HaveXInputGamepad(i)) {
continue;