Bug 1404035 Address an unused result warning in netwerk/socket/nsNamedPipeIOLayer.cpp draft
authorTom Ritter <tom@mozilla.com>
Tue, 10 Oct 2017 13:06:49 -0500
changeset 677754 73fdc19b45771e2f778b8187dc22ce88368fb087
parent 677753 035475c42d6c3ae841e4cb1d2ed37e2a9570adee
child 677756 72b358567d6004bf47910344c4102c27d88520e6
push id83797
push userbmo:tom@mozilla.com
push dateTue, 10 Oct 2017 18:10:48 +0000
bugs1404035
milestone58.0a1
Bug 1404035 Address an unused result warning in netwerk/socket/nsNamedPipeIOLayer.cpp If we fail, we should fail. MozReview-Commit-ID: KxtIx91nG3v
netwerk/socket/nsNamedPipeIOLayer.cpp
old mode 100644
new mode 100755
--- a/netwerk/socket/nsNamedPipeIOLayer.cpp
+++ b/netwerk/socket/nsNamedPipeIOLayer.cpp
@@ -293,32 +293,33 @@ NamedPipeInfo::Connect(const nsACString&
 }
 
 nsresult
 NamedPipeInfo::Disconnect()
 {
   MOZ_ASSERT(OnSocketThread(), "not on socket thread");
 
   nsresult rv = mNamedPipeService->RemoveDataObserver(mPipe, this);
-  NS_WARN_IF(NS_FAILED(rv));
+  Unused << NS_WARN_IF(NS_FAILED(rv));
+
   mPipe = nullptr;
 
   if (mReadOverlapped.hEvent &&
       mReadOverlapped.hEvent != INVALID_HANDLE_VALUE) {
     CloseHandle(mReadOverlapped.hEvent);
     mReadOverlapped.hEvent = nullptr;
   }
 
   if (mWriteOverlapped.hEvent &&
       mWriteOverlapped.hEvent != INVALID_HANDLE_VALUE) {
     CloseHandle(mWriteOverlapped.hEvent);
     mWriteOverlapped.hEvent = nullptr;
   }
 
-  return NS_OK;
+  return rv;
 }
 
 int32_t
 NamedPipeInfo::Read(void* aBuffer, int32_t aSize)
 {
   MOZ_ASSERT(OnSocketThread(), "not on socket thread");
 
   int32_t bytesRead = Peek(aBuffer, aSize);