Bug 1404035 Address an unused result warning in netwerk/socket/nsNamedPipeIOLayer.cpp
If we fail, we should fail.
MozReview-Commit-ID: KxtIx91nG3v
old mode 100644
new mode 100755
--- a/netwerk/socket/nsNamedPipeIOLayer.cpp
+++ b/netwerk/socket/nsNamedPipeIOLayer.cpp
@@ -293,32 +293,33 @@ NamedPipeInfo::Connect(const nsACString&
}
nsresult
NamedPipeInfo::Disconnect()
{
MOZ_ASSERT(OnSocketThread(), "not on socket thread");
nsresult rv = mNamedPipeService->RemoveDataObserver(mPipe, this);
- NS_WARN_IF(NS_FAILED(rv));
+ Unused << NS_WARN_IF(NS_FAILED(rv));
+
mPipe = nullptr;
if (mReadOverlapped.hEvent &&
mReadOverlapped.hEvent != INVALID_HANDLE_VALUE) {
CloseHandle(mReadOverlapped.hEvent);
mReadOverlapped.hEvent = nullptr;
}
if (mWriteOverlapped.hEvent &&
mWriteOverlapped.hEvent != INVALID_HANDLE_VALUE) {
CloseHandle(mWriteOverlapped.hEvent);
mWriteOverlapped.hEvent = nullptr;
}
- return NS_OK;
+ return rv;
}
int32_t
NamedPipeInfo::Read(void* aBuffer, int32_t aSize)
{
MOZ_ASSERT(OnSocketThread(), "not on socket thread");
int32_t bytesRead = Peek(aBuffer, aSize);