Bug 1402921 - Enhance browser_ext_tabs_readerMode to verify that correct isInReaderMode is reported for onUpdated, r?mixedpuppy draft
authorBob Silverberg <bsilverberg@mozilla.com>
Thu, 28 Sep 2017 07:37:35 -0400
changeset 678176 4fc956521ecc921d412ab9323e06993da79825e7
parent 677774 a0488ecc201c04f2617e7b02f039344e8fbf0d9a
child 735249 edf6b5c0fdb8a8e3bf5c181d13f458304e501f38
push id83839
push userbmo:bob.silverberg@gmail.com
push dateTue, 10 Oct 2017 21:19:13 +0000
reviewersmixedpuppy
bugs1402921
milestone58.0a1
Bug 1402921 - Enhance browser_ext_tabs_readerMode to verify that correct isInReaderMode is reported for onUpdated, r?mixedpuppy All of the information needed for an extension to watch for tabs moving in and out of reader mode is already available in the onUpdated event. This adds some asserts to the existing test to check that this information is accurate. MozReview-Commit-ID: 7OkR933MUPl
browser/components/extensions/test/browser/browser_ext_tabs_readerMode.js
--- a/browser/components/extensions/test/browser/browser_ext_tabs_readerMode.js
+++ b/browser/components/extensions/test/browser/browser_ext_tabs_readerMode.js
@@ -81,23 +81,26 @@ add_task(async function test_reader_mode
   let tab = await extension.awaitMessage("isArticle");
 
   ok(!tab.url.startsWith(READER_MODE_PREFIX), "Tab url does not indicate reader mode.");
   ok(tab.isArticle, "Tab is readerable.");
 
   extension.sendMessage("enterReaderMode", true);
   tab = await extension.awaitMessage("tabUpdated");
   ok(tab.url.startsWith(READER_MODE_PREFIX), "Tab url indicates reader mode.");
+  ok(tab.isInReaderMode, "tab.isInReaderMode indicates reader mode.");
 
   extension.sendMessage("leaveReaderMode");
   tab = await extension.awaitMessage("tabUpdated");
   ok(!tab.url.startsWith(READER_MODE_PREFIX), "Tab url does not indicate reader mode.");
+  ok(!tab.isInReaderMode, "tab.isInReaderMode does not indicate reader mode.");
 
   extension.sendMessage("updateUrl", false, `${TEST_PATH}readerModeNonArticle.html`);
   tab = await extension.awaitMessage("tabUpdated");
   ok(!tab.url.startsWith(READER_MODE_PREFIX), "Tab url does not indicate reader mode.");
   ok(!tab.isArticle, "Tab is not readerable.");
+  ok(!tab.isInReaderMode, "tab.isInReaderMode does not indicate reader mode.");
 
   extension.sendMessage("enterReaderMode", false);
   await extension.awaitMessage("enterFailed");
 
   await extension.unload();
 });