Bug 1403444 - Trivially expand rbp_{color,red,black}_set. r?njn draft
authorMike Hommey <mh+mozilla@glandium.org>
Mon, 25 Sep 2017 10:03:56 +0900
changeset 671614 67033d062c23a69f8e0cc8bb6a95c265a0fff377
parent 671613 dea8802418499042fe137a58304882509f70971b
child 671615 2846808ca3a05d0d23be141af9a6454f3a2c2519
push id81993
push userbmo:mh+mozilla@glandium.org
push dateThu, 28 Sep 2017 04:40:59 +0000
reviewersnjn
bugs1403444
milestone58.0a1
Bug 1403444 - Trivially expand rbp_{color,red,black}_set. r?njn
memory/build/rb.h
--- a/memory/build/rb.h
+++ b/memory/build/rb.h
@@ -131,39 +131,30 @@ template <typename T>
 struct RedBlackTree
 {
   T* rbt_root;
   T rbt_nil;
 };
 
 #define rb_node_field(a_node, a_field) (a_node)->a_field
 
-/* Color accessors. */
-#define rbp_color_set(a_type, a_field, a_node, a_red)                          \
-  rb_node_field(a_node, a_field)                                               \
-    .SetColor(a_red ? NodeColor::Red : NodeColor::Black)
-#define rbp_red_set(a_type, a_field, a_node)                                   \
-  rb_node_field(a_node, a_field).SetColor(NodeColor::Red)
-#define rbp_black_set(a_type, a_field, a_node)                                 \
-  rb_node_field(a_node, a_field).SetColor(NodeColor::Black)
-
 /* Node initializer. */
 #define rbp_node_new(a_type, a_field, a_tree, a_node)                          \
   do {                                                                         \
     rb_node_field((a_node), a_field).SetLeft(&(a_tree)->rbt_nil);              \
     rb_node_field((a_node), a_field).SetRight(&(a_tree)->rbt_nil);             \
-    rbp_red_set(a_type, a_field, (a_node));                                    \
+    rb_node_field((a_node), a_field).SetColor(NodeColor::Red);                 \
   } while (0)
 
 /* Tree initializer. */
 #define rb_new(a_type, a_field, a_tree)                                        \
   do {                                                                         \
     (a_tree)->rbt_root = &(a_tree)->rbt_nil;                                   \
     rbp_node_new(a_type, a_field, a_tree, &(a_tree)->rbt_nil);                 \
-    rbp_black_set(a_type, a_field, &(a_tree)->rbt_nil);                        \
+    rb_node_field(&(a_tree)->rbt_nil, a_field).SetColor(NodeColor::Black);     \
   } while (0)
 
 /* Tree operations. */
 #define rbp_first(a_type, a_field, a_tree, a_root, r_node)                     \
   do {                                                                         \
     for ((r_node) = (a_root);                                                  \
          rb_node_field((r_node), a_field).Left() != &(a_tree)->rbt_nil;        \
          (r_node) = rb_node_field((r_node), a_field).Left()) {                 \
@@ -323,90 +314,92 @@ struct RedBlackTree
     rb_node_field((r_node), a_field).SetRight((a_node));                       \
   } while (0)
 
 #define rbp_lean_left(a_type, a_field, a_node, r_node)                         \
   do {                                                                         \
     bool rbp_ll_red;                                                           \
     rbp_rotate_left(a_type, a_field, (a_node), (r_node));                      \
     rbp_ll_red = rb_node_field((a_node), a_field).IsRed();                     \
-    rbp_color_set(a_type, a_field, (r_node), rbp_ll_red);                      \
-    rbp_red_set(a_type, a_field, (a_node));                                    \
+    rb_node_field((r_node), a_field)                                           \
+      .SetColor(rbp_ll_red ? NodeColor::Red : NodeColor::Black);               \
+    rb_node_field((a_node), a_field).SetColor(NodeColor::Red);                 \
   } while (0)
 
 #define rbp_lean_right(a_type, a_field, a_node, r_node)                        \
   do {                                                                         \
     bool rbp_lr_red;                                                           \
     rbp_rotate_right(a_type, a_field, (a_node), (r_node));                     \
     rbp_lr_red = rb_node_field((a_node), a_field).IsRed();                     \
-    rbp_color_set(a_type, a_field, (r_node), rbp_lr_red);                      \
-    rbp_red_set(a_type, a_field, (a_node));                                    \
+    rb_node_field((r_node), a_field)                                           \
+      .SetColor(rbp_lr_red ? NodeColor::Red : NodeColor::Black);               \
+    rb_node_field((a_node), a_field).SetColor(NodeColor::Red);                 \
   } while (0)
 
 #define rbp_move_red_left(a_type, a_field, a_node, r_node)                     \
   do {                                                                         \
     a_type *rbp_mrl_t, *rbp_mrl_u;                                             \
     rbp_mrl_t = rb_node_field((a_node), a_field).Left();                       \
-    rbp_red_set(a_type, a_field, rbp_mrl_t);                                   \
+    rb_node_field(rbp_mrl_t, a_field).SetColor(NodeColor::Red);                \
     rbp_mrl_t = rb_node_field((a_node), a_field).Right();                      \
     rbp_mrl_u = rb_node_field(rbp_mrl_t, a_field).Left();                      \
     if (rb_node_field(rbp_mrl_u, a_field).IsRed()) {                           \
       rbp_rotate_right(a_type, a_field, rbp_mrl_t, rbp_mrl_u);                 \
       rb_node_field((a_node), a_field).SetRight(rbp_mrl_u);                    \
       rbp_rotate_left(a_type, a_field, (a_node), (r_node));                    \
       rbp_mrl_t = rb_node_field((a_node), a_field).Right();                    \
       if (rb_node_field(rbp_mrl_t, a_field).IsRed()) {                         \
-        rbp_black_set(a_type, a_field, rbp_mrl_t);                             \
-        rbp_red_set(a_type, a_field, (a_node));                                \
+        rb_node_field(rbp_mrl_t, a_field).SetColor(NodeColor::Black);          \
+        rb_node_field((a_node), a_field).SetColor(NodeColor::Red);             \
         rbp_rotate_left(a_type, a_field, (a_node), rbp_mrl_t);                 \
         rb_node_field((r_node), a_field).SetLeft(rbp_mrl_t);                   \
       } else {                                                                 \
-        rbp_black_set(a_type, a_field, (a_node));                              \
+        rb_node_field((a_node), a_field).SetColor(NodeColor::Black);           \
       }                                                                        \
     } else {                                                                   \
-      rbp_red_set(a_type, a_field, (a_node));                                  \
+      rb_node_field((a_node), a_field).SetColor(NodeColor::Red);               \
       rbp_rotate_left(a_type, a_field, (a_node), (r_node));                    \
     }                                                                          \
   } while (0)
 
 #define rbp_move_red_right(a_type, a_field, a_node, r_node)                    \
   do {                                                                         \
     a_type* rbp_mrr_t;                                                         \
     rbp_mrr_t = rb_node_field((a_node), a_field).Left();                       \
     if (rb_node_field(rbp_mrr_t, a_field).IsRed()) {                           \
       a_type *rbp_mrr_u, *rbp_mrr_v;                                           \
       rbp_mrr_u = rb_node_field(rbp_mrr_t, a_field).Right();                   \
       rbp_mrr_v = rb_node_field(rbp_mrr_u, a_field).Left();                    \
       if (rb_node_field(rbp_mrr_v, a_field).IsRed()) {                         \
-        rbp_color_set(a_type,                                                  \
-                      a_field,                                                 \
-                      rbp_mrr_u,                                               \
-                      rb_node_field((a_node), a_field).IsRed());               \
-        rbp_black_set(a_type, a_field, rbp_mrr_v);                             \
+        rb_node_field(rbp_mrr_u, a_field)                                      \
+          .SetColor(rb_node_field((a_node), a_field).IsRed()                   \
+                      ? NodeColor::Red                                         \
+                      : NodeColor::Black);                                     \
+        rb_node_field(rbp_mrr_v, a_field).SetColor(NodeColor::Black);          \
         rbp_rotate_left(a_type, a_field, rbp_mrr_t, rbp_mrr_u);                \
         rb_node_field((a_node), a_field).SetLeft(rbp_mrr_u);                   \
         rbp_rotate_right(a_type, a_field, (a_node), (r_node));                 \
         rbp_rotate_left(a_type, a_field, (a_node), rbp_mrr_t);                 \
         rb_node_field((r_node), a_field).SetRight(rbp_mrr_t);                  \
       } else {                                                                 \
-        rbp_color_set(a_type,                                                  \
-                      a_field,                                                 \
-                      rbp_mrr_t,                                               \
-                      rb_node_field((a_node), a_field).IsRed());               \
-        rbp_red_set(a_type, a_field, rbp_mrr_u);                               \
+        rb_node_field(rbp_mrr_t, a_field)                                      \
+          .SetColor(rb_node_field((a_node), a_field).IsRed()                   \
+                      ? NodeColor::Red                                         \
+                      : NodeColor::Black);                                     \
+        rb_node_field(rbp_mrr_u, a_field).SetColor(NodeColor::Red);            \
         rbp_rotate_right(a_type, a_field, (a_node), (r_node));                 \
         rbp_rotate_left(a_type, a_field, (a_node), rbp_mrr_t);                 \
         rb_node_field((r_node), a_field).SetRight(rbp_mrr_t);                  \
       }                                                                        \
-      rbp_red_set(a_type, a_field, (a_node));                                  \
+      rb_node_field((a_node), a_field).SetColor(NodeColor::Red);               \
     } else {                                                                   \
-      rbp_red_set(a_type, a_field, rbp_mrr_t);                                 \
+      rb_node_field(rbp_mrr_t, a_field).SetColor(NodeColor::Red);              \
       rbp_mrr_t = rb_node_field(rbp_mrr_t, a_field).Left();                    \
       if (rb_node_field(rbp_mrr_t, a_field).IsRed()) {                         \
-        rbp_black_set(a_type, a_field, rbp_mrr_t);                             \
+        rb_node_field(rbp_mrr_t, a_field).SetColor(NodeColor::Black);          \
         rbp_rotate_right(a_type, a_field, (a_node), (r_node));                 \
         rbp_rotate_left(a_type, a_field, (a_node), rbp_mrr_t);                 \
         rb_node_field((r_node), a_field).SetRight(rbp_mrr_t);                  \
       } else {                                                                 \
         rbp_rotate_left(a_type, a_field, (a_node), (r_node));                  \
       }                                                                        \
     }                                                                          \
   } while (0)
@@ -414,17 +407,17 @@ struct RedBlackTree
 #define rb_insert(a_type, a_field, a_cmp, a_tree, a_node)                      \
   do {                                                                         \
     a_type rbp_i_s;                                                            \
     a_type *rbp_i_g, *rbp_i_p, *rbp_i_c, *rbp_i_t, *rbp_i_u;                   \
     int rbp_i_cmp = 0;                                                         \
     rbp_i_g = &(a_tree)->rbt_nil;                                              \
     rb_node_field(&rbp_i_s, a_field).SetLeft((a_tree)->rbt_root);              \
     rb_node_field(&rbp_i_s, a_field).SetRight(&(a_tree)->rbt_nil);             \
-    rbp_black_set(a_type, a_field, &rbp_i_s);                                  \
+    rb_node_field(&rbp_i_s, a_field).SetColor(NodeColor::Black);               \
     rbp_i_p = &rbp_i_s;                                                        \
     rbp_i_c = (a_tree)->rbt_root;                                              \
     /* Iteratively search down the tree for the insertion point,      */       \
     /* splitting 4-nodes as they are encountered.  At the end of each */       \
     /* iteration, rbp_i_g->rbp_i_p->rbp_i_c is a 3-level path down    */       \
     /* the tree, assuming a sufficiently deep tree.                   */       \
     while (rbp_i_c != &(a_tree)->rbt_nil) {                                    \
       rbp_i_t = rb_node_field(rbp_i_c, a_field).Left();                        \
@@ -434,17 +427,17 @@ struct RedBlackTree
         /* rbp_i_c is the top of a logical 4-node, so split it.   */           \
         /* This iteration does not move down the tree, due to the */           \
         /* disruptiveness of node splitting.                      */           \
         /*                                                        */           \
         /* Rotate right.                                          */           \
         rbp_rotate_right(a_type, a_field, rbp_i_c, rbp_i_t);                   \
         /* Pass red links up one level.                           */           \
         rbp_i_u = rb_node_field(rbp_i_t, a_field).Left();                      \
-        rbp_black_set(a_type, a_field, rbp_i_u);                               \
+        rb_node_field(rbp_i_u, a_field).SetColor(NodeColor::Black);            \
         if (rb_node_field(rbp_i_p, a_field).Left() == rbp_i_c) {               \
           rb_node_field(rbp_i_p, a_field).SetLeft(rbp_i_t);                    \
           rbp_i_c = rbp_i_t;                                                   \
         } else {                                                               \
           /* rbp_i_c was the right child of rbp_i_p, so rotate  */             \
           /* left in order to maintain the left-leaning         */             \
           /* invariant.                                         */             \
           MOZ_ASSERT(rb_node_field(rbp_i_p, a_field).Right() == rbp_i_c);      \
@@ -487,44 +480,44 @@ struct RedBlackTree
       } else if (rb_node_field(rbp_i_g, a_field).Right() == rbp_i_p) {         \
         rb_node_field(rbp_i_g, a_field).SetRight(rbp_i_t);                     \
       }                                                                        \
     } else {                                                                   \
       rb_node_field(rbp_i_p, a_field).SetLeft((a_node));                       \
     }                                                                          \
     /* Update the root and make sure that it is black.                */       \
     (a_tree)->rbt_root = rb_node_field(&rbp_i_s, a_field).Left();              \
-    rbp_black_set(a_type, a_field, (a_tree)->rbt_root);                        \
+    rb_node_field((a_tree)->rbt_root, a_field).SetColor(NodeColor::Black);     \
   } while (0)
 
 #define rb_remove(a_type, a_field, a_cmp, a_tree, a_node)                      \
   do {                                                                         \
     a_type rbp_r_s;                                                            \
     a_type *rbp_r_p, *rbp_r_c, *rbp_r_xp, *rbp_r_t, *rbp_r_u;                  \
     int rbp_r_cmp;                                                             \
     rb_node_field(&rbp_r_s, a_field).SetLeft((a_tree)->rbt_root);              \
     rb_node_field(&rbp_r_s, a_field).SetRight(&(a_tree)->rbt_nil);             \
-    rbp_black_set(a_type, a_field, &rbp_r_s);                                  \
+    rb_node_field(&rbp_r_s, a_field).SetColor(NodeColor::Black);               \
     rbp_r_p = &rbp_r_s;                                                        \
     rbp_r_c = (a_tree)->rbt_root;                                              \
     rbp_r_xp = &(a_tree)->rbt_nil;                                             \
     /* Iterate down the tree, but always transform 2-nodes to 3- or   */       \
     /* 4-nodes in order to maintain the invariant that the current    */       \
     /* node is not a 2-node.  This allows simple deletion once a leaf */       \
     /* is reached.  Handle the root specially though, since there may */       \
     /* be no way to convert it from a 2-node to a 3-node.             */       \
     rbp_r_cmp = (a_cmp)((a_node), rbp_r_c);                                    \
     if (rbp_r_cmp < 0) {                                                       \
       rbp_r_t = rb_node_field(rbp_r_c, a_field).Left();                        \
       rbp_r_u = rb_node_field(rbp_r_t, a_field).Left();                        \
       if (rb_node_field(rbp_r_t, a_field).IsRed() == false &&                  \
           rb_node_field(rbp_r_u, a_field).IsRed() == false) {                  \
         /* Apply standard transform to prepare for left move.     */           \
         rbp_move_red_left(a_type, a_field, rbp_r_c, rbp_r_t);                  \
-        rbp_black_set(a_type, a_field, rbp_r_t);                               \
+        rb_node_field(rbp_r_t, a_field).SetColor(NodeColor::Black);            \
         rb_node_field(rbp_r_p, a_field).SetLeft(rbp_r_t);                      \
         rbp_r_c = rbp_r_t;                                                     \
       } else {                                                                 \
         /* Move left.                                             */           \
         rbp_r_p = rbp_r_c;                                                     \
         rbp_r_c = rb_node_field(rbp_r_c, a_field).Left();                      \
       }                                                                        \
     } else {                                                                   \
@@ -555,25 +548,25 @@ struct RedBlackTree
               a_field)                                                         \
               .IsRed() == false) {                                             \
           rbp_r_t = rb_node_field(rbp_r_c, a_field).Left();                    \
           if (rb_node_field(rbp_r_t, a_field).IsRed()) {                       \
             /* Standard transform.                            */               \
             rbp_move_red_right(a_type, a_field, rbp_r_c, rbp_r_t);             \
           } else {                                                             \
             /* Root-specific transform.                       */               \
-            rbp_red_set(a_type, a_field, rbp_r_c);                             \
+            rb_node_field(rbp_r_c, a_field).SetColor(NodeColor::Red);          \
             rbp_r_u = rb_node_field(rbp_r_t, a_field).Left();                  \
             if (rb_node_field(rbp_r_u, a_field).IsRed()) {                     \
-              rbp_black_set(a_type, a_field, rbp_r_u);                         \
+              rb_node_field(rbp_r_u, a_field).SetColor(NodeColor::Black);      \
               rbp_rotate_right(a_type, a_field, rbp_r_c, rbp_r_t);             \
               rbp_rotate_left(a_type, a_field, rbp_r_c, rbp_r_u);              \
               rb_node_field(rbp_r_t, a_field).SetRight(rbp_r_u);               \
             } else {                                                           \
-              rbp_red_set(a_type, a_field, rbp_r_t);                           \
+              rb_node_field(rbp_r_t, a_field).SetColor(NodeColor::Red);        \
               rbp_rotate_left(a_type, a_field, rbp_r_c, rbp_r_t);              \
             }                                                                  \
           }                                                                    \
           rb_node_field(rbp_r_p, a_field).SetLeft(rbp_r_t);                    \
           rbp_r_c = rbp_r_t;                                                   \
         } else {                                                               \
           /* Move right.                                        */             \
           rbp_r_p = rbp_r_c;                                                   \
@@ -597,20 +590,20 @@ struct RedBlackTree
               MOZ_ASSERT(rb_node_field(rbp_r_xp, a_field).Right() ==           \
                          (a_node));                                            \
               rb_node_field(rbp_r_xp, a_field).SetRight(rbp_r_c);              \
             }                                                                  \
             rb_node_field(rbp_r_c, a_field)                                    \
               .SetLeft(rb_node_field((a_node), a_field).Left());               \
             rb_node_field(rbp_r_c, a_field)                                    \
               .SetRight(rb_node_field((a_node), a_field).Right());             \
-            rbp_color_set(a_type,                                              \
-                          a_field,                                             \
-                          rbp_r_c,                                             \
-                          rb_node_field((a_node), a_field).IsRed());           \
+            rb_node_field(rbp_r_c, a_field)                                    \
+              .SetColor(rb_node_field((a_node), a_field).IsRed()               \
+                          ? NodeColor::Red                                     \
+                          : NodeColor::Black);                                 \
             if (rb_node_field(rbp_r_p, a_field).Left() == rbp_r_c) {           \
               rb_node_field(rbp_r_p, a_field).SetLeft(&(a_tree)->rbt_nil);     \
             } else {                                                           \
               MOZ_ASSERT(rb_node_field(rbp_r_p, a_field).Right() == rbp_r_c);  \
               rb_node_field(rbp_r_p, a_field).SetRight(&(a_tree)->rbt_nil);    \
             }                                                                  \
             break;                                                             \
           }                                                                    \