Bug 1402493 - Don't prevent switching back to Reload for top level about: loads. r?gijs
In the steps to reproduce of this bug, we get see a load start for about:blank that is not top level. We then see a following load complete (STATE_STOP) that has aWebProgress.isTopLevel=true. This code is really here to prevent flickering from reload->stop->reload for about:home and other about: pages. I don't see any harm in being more agressive when switching back to Reload since that is the default state.
MozReview-Commit-ID: 3LygnRLcbA9
--- a/browser/base/content/browser.js
+++ b/browser/base/content/browser.js
@@ -5049,18 +5049,17 @@ var CombinedStopReload = {
this.stopReloadContainer.setAttribute("animate", "true");
} else {
this.stopReloadContainer.removeAttribute("animate");
}
this.reload.setAttribute("displaystop", "true");
},
switchToReload(aRequest, aWebProgress) {
- if (!this.ensureInitialized() || !this._shouldSwitch(aRequest, aWebProgress) ||
- !this.reload.hasAttribute("displaystop")) {
+ if (!this.ensureInitialized() || !this.reload.hasAttribute("displaystop")) {
return;
}
let shouldAnimate = aRequest instanceof Ci.nsIRequest &&
aWebProgress.isTopLevel &&
!aWebProgress.isLoadingDocument &&
!gBrowser.tabAnimationsInProgress &&
this._loadTimeExceedsMinimumForAnimation() &&