Bug 1247189 - part1 : should detach TBM after detaching it from demuxers.
After detaching TBM, we should not access it anymore. So we should finish all
other related detaching process, before detaching TBM.
MozReview-Commit-ID: 8bNzqXVHVyy
--- a/dom/media/mediasource/SourceBuffer.cpp
+++ b/dom/media/mediasource/SourceBuffer.cpp
@@ -275,19 +275,19 @@ SourceBuffer::Detach()
MOZ_ASSERT(NS_IsMainThread());
MSE_DEBUG("Detach");
if (!mMediaSource) {
MSE_DEBUG("Already detached");
return;
}
AbortBufferAppend();
if (mTrackBuffersManager) {
- mTrackBuffersManager->Detach();
mMediaSource->GetDecoder()->GetDemuxer()->DetachSourceBuffer(
mTrackBuffersManager);
+ mTrackBuffersManager->Detach();
}
mTrackBuffersManager = nullptr;
mMediaSource = nullptr;
}
void
SourceBuffer::Ended()
{