Bug 1403154 - Don't MOZ_CRASH in PerformanceNavigationTiming::Type if the navigation type is TYPE_RESERVED r=baku draft
authorValentin Gosu <valentin.gosu@gmail.com>
Tue, 26 Sep 2017 17:44:05 +0200
changeset 670532 854cc9d8616fa5dc8365c82b1e29a4eab91bb590
parent 670404 bc56729898954e32d3a3731d03d178ed78924c33
child 733258 6dbdf88ff70b90d6b4707c5327b5ada03125769b
push id81657
push uservalentin.gosu@gmail.com
push dateTue, 26 Sep 2017 15:49:09 +0000
reviewersbaku
bugs1403154
milestone58.0a1
Bug 1403154 - Don't MOZ_CRASH in PerformanceNavigationTiming::Type if the navigation type is TYPE_RESERVED r=baku MozReview-Commit-ID: A9lwpjRb3G6
dom/performance/PerformanceNavigationTiming.cpp
--- a/dom/performance/PerformanceNavigationTiming.cpp
+++ b/dom/performance/PerformanceNavigationTiming.cpp
@@ -78,17 +78,18 @@ PerformanceNavigationTiming::Type()
       break;
     case nsDOMNavigationTiming::TYPE_RELOAD:
       return NavigationType::Reload;
       break;
     case nsDOMNavigationTiming::TYPE_BACK_FORWARD:
       return NavigationType::Back_forward;
       break;
     default:
-      MOZ_CRASH(); // Should not happen
+      // The type is TYPE_RESERVED or some other value that was later added.
+      // We fallback to the default of Navigate.
       return NavigationType::Navigate;
   }
 }
 
 uint16_t
 PerformanceNavigationTiming::RedirectCount()
 {
   return mTiming->GetRedirectCount();