Bug 1374699 - make warnings errors on nICEr and nrappkit builds. r=ekr draft
authorMichael Froman <mfroman@mozilla.com>
Thu, 21 Sep 2017 10:29:16 -0500
changeset 793143 fa50738b5fafc1b158aa271bdec003c7dd7b3f14
parent 793142 875245ac8535225790a66ff49b2ed6efb493d983
push id109292
push userbmo:mfroman@nostrum.com
push dateWed, 09 May 2018 15:18:16 +0000
reviewersekr
bugs1374699
milestone62.0a1
Bug 1374699 - make warnings errors on nICEr and nrappkit builds. r=ekr MozReview-Commit-ID: 7nPOPzcC925
media/mtransport/third_party/moz.build
--- a/media/mtransport/third_party/moz.build
+++ b/media/mtransport/third_party/moz.build
@@ -66,19 +66,15 @@ nrappkit_non_unified_sources = [
     'nrappkit/src/util/libekr/r_replace.c',
     'nrappkit/src/util/libekr/r_time.c',
     'nrappkit/src/util/p_buf.c',
     'nrappkit/src/util/util.c',
 ]
 
 GYP_DIRS['nICEr'].input = 'nICEr/nicer.gyp'
 GYP_DIRS['nICEr'].variables = gyp_vars_copy
-# We allow warnings for third-party code that can be updated from upstream.
-GYP_DIRS['nICEr'].sandbox_vars['COMPILE_FLAGS'] = {'WARNINGS_AS_ERRORS': []}
 GYP_DIRS['nICEr'].sandbox_vars['FINAL_LIBRARY'] = 'xul'
 GYP_DIRS['nICEr'].non_unified_sources += nICEr_non_unified_sources
 
 GYP_DIRS['nrappkit'].input = 'nrappkit/nrappkit.gyp'
 GYP_DIRS['nrappkit'].variables = gyp_vars_copy
-# We allow warnings for third-party code that can be updated from upstream.
-GYP_DIRS['nrappkit'].sandbox_vars['COMPILE_FLAGS'] = {'WARNINGS_AS_ERRORS': []}
 GYP_DIRS['nrappkit'].sandbox_vars['FINAL_LIBRARY'] = 'xul'
 GYP_DIRS['nrappkit'].non_unified_sources += nrappkit_non_unified_sources