Bug 1401918 - Fix for showing "No headers" text only after request status is obtained. r=nchevobbe draft
authorabhinav <abhinav.koppula@gmail.com>
Mon, 25 Sep 2017 02:02:39 +0530
changeset 669574 fc0eebc1382539ab1742164ad5c0ad91cdc3af58
parent 668548 ca7d18dbacbf103d74a3213d8d08a7c3e4def9a2
child 732992 7d36e7c5c67c2516deb0f0d3f21febda94f2e08e
push id81368
push userbmo:abhinav.koppula@gmail.com
push dateSun, 24 Sep 2017 20:33:04 +0000
reviewersnchevobbe
bugs1401918
milestone58.0a1
Bug 1401918 - Fix for showing "No headers" text only after request status is obtained. r=nchevobbe MozReview-Commit-ID: KeVz27iqbwK
devtools/client/netmonitor/src/components/headers-panel.js
--- a/devtools/client/netmonitor/src/components/headers-panel.js
+++ b/devtools/client/netmonitor/src/components/headers-panel.js
@@ -153,24 +153,16 @@ const HeadersPanel = createClass({
         requestHeadersFromUploadStream: uploadHeaders,
         responseHeaders,
         status,
         statusText,
         urlDetails,
       },
     } = this.props;
 
-    if ((!requestHeaders || !requestHeaders.headers.length) &&
-        (!uploadHeaders || !uploadHeaders.headers.length) &&
-        (!responseHeaders || !responseHeaders.headers.length)) {
-      return div({ className: "empty-notice" },
-        HEADERS_EMPTY_TEXT
-      );
-    }
-
     let object = Object.assign({},
       this.getProperties(responseHeaders, RESPONSE_HEADERS),
       this.getProperties(requestHeaders, REQUEST_HEADERS),
       this.getProperties(uploadHeaders, REQUEST_HEADERS_FROM_UPLOAD),
     );
 
     let summaryUrl = urlDetails.unicodeUrl ?
       this.renderSummary(SUMMARY_URL, urlDetails.unicodeUrl) : null;
@@ -189,16 +181,24 @@ const HeadersPanel = createClass({
       if (fromCache) {
         code = "cached";
       } else if (fromServiceWorker) {
         code = "service worker";
       } else {
         code = status;
       }
 
+      if ((!requestHeaders || !requestHeaders.headers.length) &&
+        (!uploadHeaders || !uploadHeaders.headers.length) &&
+        (!responseHeaders || !responseHeaders.headers.length)) {
+        return div({ className: "empty-notice" },
+          HEADERS_EMPTY_TEXT
+        );
+      }
+
       let statusCodeDocURL = getHTTPStatusCodeURL(status.toString());
       let inputWidth = status.toString().length + statusText.length + 1;
       let toggleRawHeadersClassList = ["devtools-button"];
       if (this.state.rawHeadersOpened) {
         toggleRawHeadersClassList.push("checked");
       }
 
       summaryStatus = (