Bug 1401743: Disable importance for accessibility of pocket MORE arrow. r=liuche draft
authorMichael Comella <michael.l.comella@gmail.com>
Thu, 21 Sep 2017 13:20:18 -0700
changeset 668558 e31aa207b204ace35871acbded1e753fdb636874
parent 668548 ca7d18dbacbf103d74a3213d8d08a7c3e4def9a2
child 732733 75d6146f3afe5f252d697fdef9c90f8b554d2900
push id81077
push usermichael.l.comella@gmail.com
push dateThu, 21 Sep 2017 20:20:30 +0000
reviewersliuche
bugs1401743
milestone58.0a1
Bug 1401743: Disable importance for accessibility of pocket MORE arrow. r=liuche The proper solution here is to put MORE and the arrow in a single focusable container but this needs to get uplifted so I went with the simpler change. For non-visual users, there is no difference. For visual users, the only "more" is focused, rather than "more" and the arrow in one container. The code as it is slightly more complex because we have to hide and add click listeners to multiple objects. MozReview-Commit-ID: JZFLc8jvXII
mobile/android/app/src/main/res/layout/activity_stream_main_highlightstitle.xml
--- a/mobile/android/app/src/main/res/layout/activity_stream_main_highlightstitle.xml
+++ b/mobile/android/app/src/main/res/layout/activity_stream_main_highlightstitle.xml
@@ -40,11 +40,12 @@
         android:visibility="gone"/>
 
     <ImageView
         android:id="@+id/arrow_link"
         android:layout_width="wrap_content"
         android:layout_height="match_parent"
         android:layout_marginEnd="@dimen/activity_stream_base_margin"
         android:layout_marginRight="@dimen/activity_stream_base_margin"
-        android:visibility="gone"/>
+        android:visibility="gone"
+        android:importantForAccessibility="no" />
 
 </LinearLayout>