Bug 958643, part 2 - Remove always-null last argument to NativeInterface2JSObject. r=krizsa draft
authorAndrew McCreight <continuation@gmail.com>
Wed, 20 Sep 2017 10:15:06 -0700
changeset 667830 dacab11fa86757c4faea26f8324801b1f3f1e1cb
parent 667829 4837b2a49d64fff5cadab16dd7a0fb32a61184f7
child 667831 704d11432d775016b29aefb40e97d328585971ea
push id80866
push userbmo:continuation@gmail.com
push dateWed, 20 Sep 2017 20:39:49 +0000
reviewerskrizsa
bugs958643
milestone57.0a1
Bug 958643, part 2 - Remove always-null last argument to NativeInterface2JSObject. r=krizsa MozReview-Commit-ID: G9F6wlMWCl9
js/xpconnect/src/nsXPConnect.cpp
--- a/js/xpconnect/src/nsXPConnect.cpp
+++ b/js/xpconnect/src/nsXPConnect.cpp
@@ -602,25 +602,24 @@ InitClassesWithNewWrappedGlobal(JSContex
 } // namespace xpc
 
 static nsresult
 NativeInterface2JSObject(HandleObject aScope,
                          nsISupports* aCOMObj,
                          nsWrapperCache* aCache,
                          const nsIID * aIID,
                          bool aAllowWrapping,
-                         MutableHandleValue aVal,
-                         nsIXPConnectJSObjectHolder** aHolder)
+                         MutableHandleValue aVal)
 {
     AutoJSContext cx;
     JSAutoCompartment ac(cx, aScope);
 
     nsresult rv;
     xpcObjectHelper helper(aCOMObj, aCache);
-    if (!XPCConvert::NativeInterface2JSObject(aVal, aHolder, helper, aIID,
+    if (!XPCConvert::NativeInterface2JSObject(aVal, nullptr, helper, aIID,
                                               aAllowWrapping, &rv))
         return rv;
 
     MOZ_ASSERT(aAllowWrapping || !xpc::WrapperFactory::IsXrayWrapper(&aVal.toObject()),
                "Shouldn't be returning a xray wrapper here");
 
     return NS_OK;
 }
@@ -634,17 +633,17 @@ nsXPConnect::WrapNative(JSContext * aJSC
 {
     MOZ_ASSERT(aJSContext, "bad param");
     MOZ_ASSERT(aScopeArg, "bad param");
     MOZ_ASSERT(aCOMObj, "bad param");
 
     RootedObject aScope(aJSContext, aScopeArg);
     RootedValue v(aJSContext);
     nsresult rv = NativeInterface2JSObject(aScope, aCOMObj, nullptr, &aIID,
-                                           true, &v, nullptr);
+                                           true, &v);
     if (NS_FAILED(rv))
         return rv;
 
     if (!v.isObjectOrNull())
         return NS_ERROR_FAILURE;
 
     *aRetVal = v.toObjectOrNull();
     return NS_OK;
@@ -660,17 +659,17 @@ nsXPConnect::WrapNativeToJSVal(JSContext
                                MutableHandleValue aVal)
 {
     MOZ_ASSERT(aJSContext, "bad param");
     MOZ_ASSERT(aScopeArg, "bad param");
     MOZ_ASSERT(aCOMObj, "bad param");
 
     RootedObject aScope(aJSContext, aScopeArg);
     return NativeInterface2JSObject(aScope, aCOMObj, aCache, aIID,
-                                    aAllowWrapping, aVal, nullptr);
+                                    aAllowWrapping, aVal);
 }
 
 NS_IMETHODIMP
 nsXPConnect::WrapJS(JSContext * aJSContext,
                     JSObject * aJSObjArg,
                     const nsIID & aIID,
                     void * *result)
 {