Bug 1401945 - Do not use the WebRenderUserData after it's removed. r=kats draft
authorEthan Lin <ethlin@mozilla.com>
Thu, 21 Sep 2017 23:15:55 +0800
changeset 668417 16ec984b49f0b2a97d3a8aa6163f3c469545171c
parent 668407 835a92b19e3d7666890153a84bc635bc43a44cb2
child 732694 ab432dce080ed8bb925fba182d48d2958190136f
push id81036
push userbmo:ethlin@mozilla.com
push dateThu, 21 Sep 2017 16:19:05 +0000
reviewerskats
bugs1401945
milestone58.0a1
Bug 1401945 - Do not use the WebRenderUserData after it's removed. r=kats MozReview-Commit-ID: AL8tO0ZxVkF
gfx/layers/wr/WebRenderLayerManager.h
--- a/gfx/layers/wr/WebRenderLayerManager.h
+++ b/gfx/layers/wr/WebRenderLayerManager.h
@@ -274,17 +274,19 @@ private:
         MOZ_ASSERT(userDataTable->Count());
 
         userDataTable->Remove(data->GetDisplayItemKey());
 
         if (!userDataTable->Count()) {
           frame->RemoveProperty(nsIFrame::WebRenderUserDataProperty());
         }
         iter.Remove();
+        continue;
       }
+
       data->SetUsed(false);
     }
   }
 
 private:
   nsIWidget* MOZ_NON_OWNING_REF mWidget;
   nsTArray<wr::ImageKey> mImageKeysToDelete;
   // TODO - This is needed because we have some code that creates image keys