Bug 1353013 - Make TabChild::GetVisibility forward to PuppetWidget->IsVisible. r?tnikkel draft
authorMike Conley <mconley@mozilla.com>
Wed, 20 Sep 2017 17:17:34 -0400
changeset 667847 9d2183319abea2acb78814afc8a1bf92553dd8e1
parent 667637 0c49ebf4195ce51072b24aacf01eaaffdcff9be6
child 667848 88a74b30e5a11b6aad57596cd59352b938523ce4
push id80876
push usermconley@mozilla.com
push dateWed, 20 Sep 2017 21:34:56 +0000
reviewerstnikkel
bugs1353013
milestone57.0a1
Bug 1353013 - Make TabChild::GetVisibility forward to PuppetWidget->IsVisible. r?tnikkel TabChild::GetVisibility would originally return true no matter what. Now it's computed based on the visibility of the PuppetWidget hosting it, which is arguably more accurate. MozReview-Commit-ID: GU0Lui8y0BX
dom/ipc/TabChild.cpp
--- a/dom/ipc/TabChild.cpp
+++ b/dom/ipc/TabChild.cpp
@@ -924,17 +924,17 @@ NS_IMETHODIMP
 TabChild::SetFocus()
 {
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::GetVisibility(bool* aVisibility)
 {
-  *aVisibility = true;
+  *aVisibility = mPuppetWidget && mPuppetWidget->IsVisible();
   return NS_OK;
 }
 
 NS_IMETHODIMP
 TabChild::SetVisibility(bool aVisibility)
 {
   // should the platform support this? Bug 666365
   return NS_OK;