Bug 1363028: Update bookmark toolbar icons to match Photon styles. r?johannh draft
authorDave Townsend <dtownsend@oxymoronical.com>
Wed, 20 Sep 2017 15:22:01 -0700
changeset 667954 16884792fc9b2488faec88f215ed72e9b0670a29
parent 667953 a88ee0137c104a57c747cd129c45952ccf1431ad
child 732553 88b619a3ea8eb4e82b83a32ec5b6a9d0b0bfbdbc
push id80890
push userdtownsend@mozilla.com
push dateWed, 20 Sep 2017 22:49:48 +0000
reviewersjohannh
bugs1363028
milestone57.0a1
Bug 1363028: Update bookmark toolbar icons to match Photon styles. r?johannh This updates the bookmark toolbar icons to use the new Photon icons. It doesn't include new icons for tags or livemarks. MozReview-Commit-ID: 5aFc53ZKDaf
browser/themes/osx/browser.css
browser/themes/windows/browser.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -175,85 +175,62 @@
 
 #nav-bar-customization-target > #wrapper-personal-bookmarks > #personal-bookmarks {
   min-height: 32px;
   -moz-box-align: center;
 }
 
 /* ----- BOOKMARK BUTTONS ----- */
 
+.bookmark-item {
+  -moz-context-properties: fill;
+  fill: currentColor;
+}
+
 .bookmark-item[container] {
-  list-style-image: url("chrome://global/skin/tree/folder.png");
+  list-style-image: url("chrome://browser/skin/places/folder.svg");
 }
 
 .bookmark-item[container][livemark] {
-  list-style-image: url("chrome://browser/skin/page-livemarks.png");
+  list-style-image: url("chrome://browser/skin/places/folder-live.svg");
 }
 
 .bookmark-item[container][livemark] .bookmark-item {
   list-style-image: url("chrome://browser/skin/places/livemark-item.png");
   -moz-image-region: rect(0px, 16px, 16px, 0px);
 }
 
 .bookmark-item[container][livemark] .bookmark-item[visited] {
   -moz-image-region: rect(0px, 32px, 16px, 16px);
 }
 
 .bookmark-item[container][query] {
-  list-style-image: url("chrome://browser/skin/places/query.png");
+  list-style-image: url("chrome://browser/skin/places/folder-smart.svg");
 }
 
 .bookmark-item[query][tagContainer] {
   list-style-image: url("chrome://browser/skin/places/tag.png");
 }
 
 .bookmark-item[query][dayContainer] {
-  list-style-image: url("chrome://browser/skin/places/history.png");
+  list-style-image: url("chrome://browser/skin/places/history.svg");
 }
 
 .bookmark-item[query][hostContainer] {
-  list-style-image: url("chrome://global/skin/tree/folder.png");
-}
-
-.bookmark-item[query][hostContainer][open] {
-  list-style-image: url("chrome://global/skin/tree/folder.png");
+  list-style-image: url("chrome://browser/skin/places/folder.svg");
 }
 
 @media (min-resolution: 2dppx) {
-  .bookmark-item[container] {
-    list-style-image: url("chrome://global/skin/tree/folder@2x.png");
-  }
-
-  .bookmark-item[container][livemark] {
-    list-style-image: url("chrome://browser/skin/page-livemarks@2x.png");
-  }
-
   .bookmark-item[container][livemark] .bookmark-item {
     list-style-image: url("chrome://browser/skin/places/livemark-item.png");
   }
 
-  .bookmark-item[container][query] {
-    list-style-image: url("chrome://browser/skin/places/query@2x.png");
-  }
-
   .bookmark-item[query][tagContainer] {
     list-style-image: url("chrome://browser/skin/places/tag@2x.png");
   }
-
-  .bookmark-item[query][dayContainer] {
-    list-style-image: url("chrome://browser/skin/places/history@2x.png");
-  }
-
-  .bookmark-item[query][hostContainer] {
-    list-style-image: url("chrome://global/skin/tree/folder@2x.png");
-  }
-
-  .bookmark-item[query][hostContainer][open] {
-    list-style-image: url("chrome://global/skin/tree/folder@2x.png");
-  }
 }
 
 /* Workaround for native menubar inheritance */
 .openintabs-menuitem,
 .openlivemarksite-menuitem,
 .livemarkstatus-menuitem {
   list-style-image: none;
 }
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -295,64 +295,53 @@ menuitem.bookmark-item {
 .bookmark-item > .menu-iconic-left > .menu-iconic-icon {
   padding-inline-start: 0px;
 }
 
 /* ::::: bookmark items ::::: */
 
 .bookmark-item  {
   list-style-image: url("chrome://mozapps/skin/places/defaultFavicon.svg");
+  -moz-context-properties: fill;
+  fill: currentColor;
 }
 
 .bookmark-item[container] {
-  list-style-image: url("chrome://global/skin/icons/folder-item.png");
-  -moz-image-region: rect(0px, 32px, 16px, 16px);
-}
-
-.bookmark-item[container][open] {
-  -moz-image-region: rect(16px, 32px, 32px, 16px);
+  list-style-image: url("chrome://browser/skin/places/folder.svg");
 }
 
 .bookmark-item[container][livemark] {
-  list-style-image: url("chrome://browser/skin/livemark-folder.png");
-  -moz-image-region: auto;
+  list-style-image: url("chrome://browser/skin/places/folder-live.svg");
 }
 
 .bookmark-item[container][livemark] .bookmark-item {
   list-style-image: url("chrome://browser/skin/places/livemark-item.png");
   -moz-image-region: rect(0px, 16px, 16px, 0px);
 }
 
 .bookmark-item[container][livemark] .bookmark-item[visited] {
   -moz-image-region: rect(0px, 32px, 16px, 16px);
 }
 
 .bookmark-item[container][query] {
-  list-style-image: url("chrome://browser/skin/places/query.png");
-  -moz-image-region: auto;
+  list-style-image: url("chrome://browser/skin/places/folder-smart.svg");
 }
 
 .bookmark-item[query][tagContainer] {
   list-style-image: url("chrome://browser/skin/places/tag.png");
   -moz-image-region: auto;
 }
 
 .bookmark-item[query][dayContainer] {
-  list-style-image: url("chrome://browser/skin/places/calendar.png");
+  list-style-image: url("chrome://browser/skin/places/history.svg");
   -moz-image-region: auto;
 }
 
 .bookmark-item[query][hostContainer] {
-  list-style-image: url("chrome://global/skin/icons/folder-item.png");
-  -moz-image-region: rect(0px, 32px, 16px, 16px);
-}
-
-.bookmark-item[query][hostContainer][open] {
-  list-style-image: url("chrome://global/skin/icons/folder-item.png");
-  -moz-image-region: rect(16px, 32px, 32px, 16px);
+  list-style-image: url("chrome://browser/skin/places/folder.svg");
 }
 
 .bookmark-item[cutting] > .toolbarbutton-icon,
 .bookmark-item[cutting] > .menu-iconic-left > .menu-iconic-icon {
   opacity: 0.5;
 }
 
 .bookmark-item[cutting] > .toolbarbutton-text,