Bug 1385233 - Fixed the moz.build so that preprocessor instructions are no longer required in bootstrap.js. r?jaws draft
authorgrenewode <grenewodemiller@gmail.com>
Tue, 19 Sep 2017 19:08:01 -0400
changeset 667348 f03ddea5a3594cfd77bc4e70c343fa014b35643f
parent 667303 a0eb21bf55e1c1ae0ba311e6f2273da05c712799
child 676473 b3e4cbb7a9ef77a4690b592ea035dbbeac5da6e0
child 677044 77dec54c9237e3df17afad9d8960169c15501227
child 680427 81b8d1001c35d242151fe65eed1c55b21ae96b32
child 680430 3a488559a81104f089fb3bc08fd5a10222d602bd
push id80678
push userbmo:mill2540@msu.edu
push dateWed, 20 Sep 2017 00:07:11 +0000
reviewersjaws
bugs1385233
milestone57.0a1
Bug 1385233 - Fixed the moz.build so that preprocessor instructions are no longer required in bootstrap.js. r?jaws moz.build had bootstrap.js in FINAL_TARGET_PP_FILES which invokes preprocessing. Solved by moving bootstrap.js to FINAL_TARGET_FILES. MozReview-Commit-ID: 8Sk8Cu5eFn9
browser/tools/mozscreenshots/mozscreenshots/extension/bootstrap.js
browser/tools/mozscreenshots/mozscreenshots/extension/moz.build
--- a/browser/tools/mozscreenshots/mozscreenshots/extension/bootstrap.js
+++ b/browser/tools/mozscreenshots/mozscreenshots/extension/bootstrap.js
@@ -1,16 +1,11 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-/*
-#if 0
-Workaround a build system bug where this file doesn't get packaged if not pre-processed.
-#endif
-*/
 
 /* exported install, uninstall, startup, shutdown */
 
 "use strict";
 
 const {classes: Cc, interfaces: Ci, utils: Cu} = Components;
 
 Cu.import("resource://gre/modules/XPCOMUtils.jsm");
--- a/browser/tools/mozscreenshots/mozscreenshots/extension/moz.build
+++ b/browser/tools/mozscreenshots/mozscreenshots/extension/moz.build
@@ -6,12 +6,15 @@
 
 XPI_NAME = 'mozscreenshots'
 
 JAR_MANIFESTS += ['jar.mn']
 
 USE_EXTENSION_MANIFEST = True
 NO_JS_MANIFEST = True
 
+FINAL_TARGET_FILES += [
+    'bootstrap.js'
+]
+
 FINAL_TARGET_PP_FILES += [
-    'bootstrap.js',
     'install.rdf',
 ]