Bug 1401385: Add Pin to Top Sites to missing configurations. r=liuche draft
authorMichael Comella <michael.l.comella@gmail.com>
Tue, 19 Sep 2017 15:53:44 -0700
changeset 667330 ea0a8606d8bd9cc82c020102a25f2f59724be1f6
parent 666598 30a386ff1192cba08a2f899343f81f6946bc6148
child 732343 015c4c105953e32c45984eb02d6dd23a66431ba9
push id80666
push usermichael.l.comella@gmail.com
push dateTue, 19 Sep 2017 22:55:40 +0000
reviewersliuche
bugs1401385
milestone57.0a1
Bug 1401385: Add Pin to Top Sites to missing configurations. r=liuche When I implemented this, I forgot to add it to non-phone configurations. MozReview-Commit-ID: 4zTrYZm5tXR
mobile/android/app/src/main/res/menu-large-v26/browser_app_menu.xml
mobile/android/app/src/main/res/menu-large/browser_app_menu.xml
mobile/android/app/src/main/res/menu-v26/browser_app_menu.xml
mobile/android/app/src/main/res/menu-xlarge-v26/browser_app_menu.xml
mobile/android/app/src/main/res/menu-xlarge/browser_app_menu.xml
--- a/mobile/android/app/src/main/res/menu-large-v26/browser_app_menu.xml
+++ b/mobile/android/app/src/main/res/menu-large-v26/browser_app_menu.xml
@@ -69,16 +69,20 @@
                   android:title="@string/save_as_pdf"/>
 
             <item android:id="@+id/print"
                   android:title="@string/print"/>
 
             <item android:id="@+id/add_search_engine"
                   android:title="@string/contextmenu_add_search_engine"/>
 
+            <!-- Title is overridden dynamically (it can also be for unpinning). -->
+            <item android:id="@+id/pin_to_top_sites"
+                  android:title="@string/contextmenu_pin_to_top_sites"/>
+
             <item android:id="@+id/set_as_homepage"
                   android:title="@string/contextmenu_set_as_homepage"/>
 
         </menu>
 
     </item>
 
     <item android:id="@+id/tools"
--- a/mobile/android/app/src/main/res/menu-large/browser_app_menu.xml
+++ b/mobile/android/app/src/main/res/menu-large/browser_app_menu.xml
@@ -69,16 +69,20 @@
                   android:title="@string/save_as_pdf"/>
 
             <item android:id="@+id/print"
                   android:title="@string/print"/>
 
             <item android:id="@+id/add_search_engine"
                   android:title="@string/contextmenu_add_search_engine"/>
 
+            <!-- Title is overridden dynamically (it can also be for unpinning). -->
+            <item android:id="@+id/pin_to_top_sites"
+                  android:title="@string/contextmenu_pin_to_top_sites"/>
+
             <item android:id="@+id/add_to_launcher"
                   android:title="@string/contextmenu_add_to_launcher"/>
 
             <item android:id="@+id/set_as_homepage"
                   android:title="@string/contextmenu_set_as_homepage"/>
 
         </menu>
 
--- a/mobile/android/app/src/main/res/menu-v26/browser_app_menu.xml
+++ b/mobile/android/app/src/main/res/menu-v26/browser_app_menu.xml
@@ -69,16 +69,20 @@
                   android:title="@string/save_as_pdf"/>
 
             <item android:id="@+id/print"
                   android:title="@string/print"/>
 
             <item android:id="@+id/add_search_engine"
                   android:title="@string/contextmenu_add_search_engine"/>
 
+            <!-- Title is overridden dynamically (it can also be for unpinning). -->
+            <item android:id="@+id/pin_to_top_sites"
+                  android:title="@string/contextmenu_pin_to_top_sites"/>
+
             <item android:id="@+id/set_as_homepage"
                   android:title="@string/contextmenu_set_as_homepage"/>
 
         </menu>
 
     </item>
 
     <item android:id="@+id/tools"
--- a/mobile/android/app/src/main/res/menu-xlarge-v26/browser_app_menu.xml
+++ b/mobile/android/app/src/main/res/menu-xlarge-v26/browser_app_menu.xml
@@ -70,16 +70,20 @@
                   android:title="@string/save_as_pdf"/>
 
             <item android:id="@+id/print"
                   android:title="@string/print"/>
 
             <item android:id="@+id/add_search_engine"
                   android:title="@string/contextmenu_add_search_engine"/>
 
+            <!-- Title is overridden dynamically (it can also be for unpinning). -->
+            <item android:id="@+id/pin_to_top_sites"
+                  android:title="@string/contextmenu_pin_to_top_sites"/>
+
             <item android:id="@+id/set_as_homepage"
                   android:title="@string/contextmenu_set_as_homepage"/>
 
         </menu>
 
     </item>
 
     <item android:id="@+id/tools"
--- a/mobile/android/app/src/main/res/menu-xlarge/browser_app_menu.xml
+++ b/mobile/android/app/src/main/res/menu-xlarge/browser_app_menu.xml
@@ -70,16 +70,20 @@
                   android:title="@string/save_as_pdf"/>
 
             <item android:id="@+id/print"
                   android:title="@string/print"/>
 
             <item android:id="@+id/add_search_engine"
                   android:title="@string/contextmenu_add_search_engine"/>
 
+            <!-- Title is overridden dynamically (it can also be for unpinning). -->
+            <item android:id="@+id/pin_to_top_sites"
+                  android:title="@string/contextmenu_pin_to_top_sites"/>
+
             <item android:id="@+id/add_to_launcher"
                   android:title="@string/contextmenu_add_to_launcher"/>
 
             <item android:id="@+id/set_as_homepage"
                   android:title="@string/contextmenu_set_as_homepage"/>
 
         </menu>