Bug 1400886 - Re-enable JSM shared global on mobile; r=me draft
authorJim Chen <nchen@mozilla.com>
Tue, 19 Sep 2017 14:57:33 -0400
changeset 667142 4f4b9e9ac92d08366c97e720106b023e1b1da584
parent 667141 d96dfec7883c123cd97e21a2ddc95f65dfe5ba9b
child 667170 8abd345a56058afb663f7eef54dca568992b0a2f
push id80621
push userbmo:nchen@mozilla.com
push dateTue, 19 Sep 2017 18:57:51 +0000
reviewersme
bugs1400886, 1400489
milestone57.0a1
Bug 1400886 - Re-enable JSM shared global on mobile; r=me Back out the change made in bug 1400489, to re-enable shared global for JSMs on mobile. r=me for trivial patch. MozReview-Commit-ID: 5Kn5LFK66w8
browser/app/profile/firefox.js
modules/libpref/init/all.js
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -506,18 +506,16 @@ pref("browser.bookmarks.openInTabClosesM
 
 // Scripts & Windows prefs
 pref("dom.disable_open_during_load",              true);
 pref("javascript.options.showInConsole",          true);
 #ifdef DEBUG
 pref("general.warnOnAboutConfig",                 false);
 #endif
 
-pref("jsloader.shareGlobal", true);
-
 // This is the pref to control the location bar, change this to true to
 // force this - this makes the origin of popup windows more obvious to avoid
 // spoofing. We would rather not do it by default because it affects UE for web
 // applications, but without it there isn't a really good way to prevent chrome
 // spoofing, see bug 337344
 pref("dom.disable_window_open_feature.location",  true);
 // prevent JS from setting status messages
 pref("dom.disable_window_status_change",          true);
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -5242,17 +5242,17 @@ pref("dom.idle-observers-api.fuzz_time.d
 // they are handled separately. This pref is only read once at startup:
 // a restart is required to enable a new value.
 pref("network.activity.blipIntervalMilliseconds", 0);
 
 // If true, reuse the same global for (almost) everything loaded by the component
 // loader (JS components, JSMs, etc). This saves memory, but makes it possible
 // for the scripts to interfere with each other.  A restart is required for this
 // to take effect.
-pref("jsloader.shareGlobal", false);
+pref("jsloader.shareGlobal", true);
 
 // When we're asked to take a screenshot, don't wait more than 2000ms for the
 // event loop to become idle before actually taking the screenshot.
 pref("dom.browserElement.maxScreenshotDelayMS", 2000);
 
 // Whether we should show the placeholder when the element is focused but empty.
 pref("dom.placeholder.show_on_focus", true);