Bug 792808 - Change js/xpconnect to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r?bz draft
authorThomas Wisniewski <wisniewskit@gmail.com>
Sun, 21 Jan 2018 14:46:11 -0500
changeset 756145 020661b25fe3d15d7162f46ecb3240d0a5d903a8
parent 756144 595df7b89b706c3737b3b90e1ddfb8744a2fae4e
child 756146 4acf6ae407847e1329381db93e0ed5123b9cb03b
push id99394
push userwisniewskit@gmail.com
push dateFri, 16 Feb 2018 14:37:01 +0000
reviewersbz
bugs792808
milestone60.0a1
Bug 792808 - Change js/xpconnect to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r?bz MozReview-Commit-ID: DZZ9NUysT5I
js/xpconnect/tests/unit/test_sandbox_metadata.js
--- a/js/xpconnect/tests/unit/test_sandbox_metadata.js
+++ b/js/xpconnect/tests/unit/test_sandbox_metadata.js
@@ -6,16 +6,18 @@
 
 function run_test()
 {
   let sandbox = Components.utils.Sandbox("http://www.blah.com", {
     metadata: "test metadata",
     addonId: "12345"
   });
 
+  Components.utils.importGlobalProperties(["XMLHttpRequest"]);
+
   Assert.equal(Components.utils.getSandboxMetadata(sandbox), "test metadata");
   Assert.equal(Components.utils.getSandboxAddonId(sandbox), "12345");
 
   sandbox = Components.utils.Sandbox("http://www.blah.com", {
     metadata: { foopy: { bar: 2 }, baz: "hi" }
   });
 
   let metadata = Components.utils.getSandboxMetadata(sandbox);
@@ -28,18 +30,17 @@ function run_test()
 
   metadata = { foo: "bar" };
   Components.utils.setSandboxMetadata(sandbox, metadata);
   metadata.foo = "baz";
   metadata = Components.utils.getSandboxMetadata(sandbox);
   Assert.equal(metadata.foo, "bar");
 
   let thrown = false;
-  let reflector = Components.classes["@mozilla.org/xmlextras/xmlhttprequest;1"]
-                    .createInstance(Components.interfaces.nsIXMLHttpRequest);
+  let reflector = new XMLHttpRequest();
 
   try {
     Components.utils.setSandboxMetadata(sandbox, { foo: reflector });
   } catch(e) {
     thrown = true;
   }
 
   Assert.equal(thrown, true);