Bug 1400354 - Include pdbstr.exe in toolchain archive; r?ted draft
authorgps@mozilla.com
Fri, 15 Sep 2017 17:59:51 -0700
changeset 665843 73a3f474ed2fb25923cd7b18291fddf7dc787304
parent 665842 ae7bd6978890f2a9b35f5e0dc6f6953f8b3a207a
child 665844 46f4c5ceced4223a7106caaf4784011c2f838fc2
push id80208
push usergszorc@mozilla.com
push dateSat, 16 Sep 2017 03:38:18 +0000
reviewersted
bugs1400354
milestone57.0a1
Bug 1400354 - Include pdbstr.exe in toolchain archive; r?ted The Visual Studio toolchain archive already contains files from the Windows 10 SDK. pdbstr.exe is part of the Windows SDK. So let's grab it from there. MozReview-Commit-ID: DHqM8Q0KGmb
build/docs/toolchains.rst
build/windows_toolchain.py
--- a/build/docs/toolchains.rst
+++ b/build/docs/toolchains.rst
@@ -31,30 +31,39 @@ publicly. However, the same tool can be 
 Configuring Your System
 -----------------------
 
 It is **highly** recommended to perform this process on a fresh installation
 of Windows 7 or 10 (such as in a VM). Installing all updates through
 Windows Update is not only acceptable - it is encouraged. Although it
 shouldn't matter.
 
-Next, install Visual Studio 2015 Community. The download link can be
-found at https://www.visualstudio.com/en-us/products/visual-studio-community-vs.aspx.
-Be sure to follow these install instructions:
+Next, install Visual Studio 2015 Community. Microsoft isn't offering
+downloads of prior versions via the public website. So you'll need to sign
+up for an account to get the download link. Load
+https://my.visualstudio.com/downloads?q=visual%20studio%20community%202015,
+sign in, and download the Visual Studio 2015 Community installer and run it.
+Then follow these install instructions:
 
 1. Choose a ``Custom`` installation and click ``Next``
 2. Select ``Programming Languages`` -> ``Visual C++`` (make sure all sub items are
    selected)
 3. Under ``Windows and Web Development`` uncheck everything except
    ``Universal Windows App Development Tools`` and the items under it
    (should be ``Tools (1.3.1)...`` and the ``Windows 10 SDK``).
 
-Once Visual Studio 2015 Community has been installed, from a checkout
-of mozilla-central, run something like the following to produce a ZIP
-archive::
+Next, install the Debugging Tools for Windows via the Windows 10 SDK installer.
+
+1. Download and run the installer at
+   https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk
+2. Select the ``Debugging Tools for Windows`` checkbox and uncheck everything
+   else.
+
+Once the prerequisites are installed, from a checkout of mozilla-central,
+run something like the following to produce a ZIP archive::
 
    $ ./mach python build/windows_toolchain.py create-zip vs2015u3
 
 The produced archive will be the argument to ``create-zip`` + ``.zip``.
 
 Firefox for Android with Gradle
 ===============================
 
--- a/build/windows_toolchain.py
+++ b/build/windows_toolchain.py
@@ -87,16 +87,19 @@ VS_PATTERNS = [
 SDK_RELEASE = '10.0.14393.0'
 
 # Files from the Windows 10 SDK to install.
 SDK_PATTERNS = [
     {
         'pattern': 'bin/x64/**',
     },
     {
+        'pattern': 'Debuggers/x64/srcsrv/**',
+    },
+    {
         'pattern': 'Include/%s/**' % SDK_RELEASE,
     },
     {
         'pattern': 'Lib/%s/ucrt/x64/**' % SDK_RELEASE,
     },
     {
         'pattern': 'Lib/%s/ucrt/x86/**' % SDK_RELEASE,
     },