Bug 1397847: --from-builds is a dev tool, not for automation; r?glandium draft
authorDustin J. Mitchell <dustin@mozilla.com>
Fri, 15 Sep 2017 12:26:14 +0000
changeset 665457 5da5cf9bf3583621dd5cfaa4d64e41b9a039fc07
parent 665129 19b510af2b7a6fe8b71f55fbb3d51d0a7696b54c
child 731781 7ff0e3bed83e58e5be5d1023c5366a81142e00b7
push id80061
push userdmitchell@mozilla.com
push dateFri, 15 Sep 2017 12:41:10 +0000
reviewersglandium
bugs1397847
milestone57.0a1
Bug 1397847: --from-builds is a dev tool, not for automation; r?glandium MozReview-Commit-ID: EGs3Zy012JA
python/mozbuild/mozbuild/mach_commands.py
--- a/python/mozbuild/mozbuild/mach_commands.py
+++ b/python/mozbuild/mozbuild/mach_commands.py
@@ -1877,16 +1877,20 @@ class PackageFrontend(MachCommandBase):
                                         record.digest)
                 records[record.filename] = DownloadRecord(
                     url, record.filename, record.size, record.digest,
                     record.algorithm, unpack=record.unpack,
                     version=record.version, visibility=record.visibility,
                     setup=record.setup)
 
         if from_build:
+            if 'TASK_ID' in os.environ:
+                self.log(logging.ERROR, 'artifact', {},
+                         'Do not use --from-build in automation; all dependencies '
+                         'should be determined in the decision task.')
             toolchains = load_toolchain_definitions()
             for b in from_build:
                 user_value = b
 
                 if b.startswith('toolchain-'):
                     b = b.replace('toolchain-', '')
 
                 if b not in toolchains: