Bug 1399930 - Add drag space padding to the tabs toolbar on OSX. r=Gijs draft
authorJohann Hofmann <jhofmann@mozilla.com>
Fri, 15 Sep 2017 12:55:18 +0200
changeset 665428 667b131485658927fc2f3d484b2ab15cce782d95
parent 665390 893fe1549e1e7342a66514b65960f08d40810a34
child 731766 379776eb07b77747a060da9501247482d5ee180d
push id80046
push userbmo:jhofmann@mozilla.com
push dateFri, 15 Sep 2017 10:55:58 +0000
reviewersGijs
bugs1399930
milestone57.0a1
Bug 1399930 - Add drag space padding to the tabs toolbar on OSX. r=Gijs The previous drag space was only set as min-height on the titlebar, which led tabsintitlebar.js to not account that extra space for moving the titlebar to the bottom (because it calculates that height from tab strip height). So while it looked fine visually, the titlebar did not stretch all the way to the bottom, so that e.g. double-clicks aren't registered correctly. MozReview-Commit-ID: 1mHFDBUe3sC
browser/themes/osx/browser.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -882,28 +882,28 @@ html|span.ac-emphasize-text-url {
 .tabbrowser-tab:focus > .tab-stack > .tab-content > .tab-throbber[pinned] {
   box-shadow: var(--focus-ring-box-shadow);
 }
 
 #TabsToolbar {
   -moz-appearance: none;
   /* overlap the nav-bar's top border */
   margin-bottom: calc(-1 * var(--tab-toolbar-navbar-overlap));
+  padding-top: var(--space-above-tabbar);
 }
 
 :root:not([customizing]):not([tabsintitlebar]):not([inFullscreen]) #TabsToolbar:not(:-moz-lwtheme) {
   -moz-appearance: toolbar;
 }
 
 #TabsToolbar:not(:-moz-lwtheme) {
   color: #333;
   text-shadow: @loweredShadow@;
 }
 
-#main-window[tabsintitlebar] > #titlebar:not(:-moz-lwtheme),
 :root:-moz-any([inFullscreen], [tabsintitlebar]) #TabsToolbar:not(:-moz-lwtheme) {
   -moz-appearance: -moz-mac-vibrancy-dark;
   -moz-font-smoothing-background-color: -moz-mac-vibrancy-dark;
   background-color: #232323;
   color: hsl(240, 9%, 98%);
   text-shadow: none;
 }