Bug 1399805 - fix the default path of fix_macosx_stack.py for running wpt tests. draft
authorJeremy Chen <jeremychen@mozilla.com>
Thu, 14 Sep 2017 19:07:23 +0800
changeset 664854 ebb0978206059dc8b44edd47e03ab99a57d1ce96
parent 664722 6266decf217d4da5a18115cb5b1ff70feb76e7a5
child 731560 3ba77dcbae5c04ed34808a65a350f712cc301bc2
push id79822
push userbmo:jeremychen@mozilla.com
push dateThu, 14 Sep 2017 13:19:07 +0000
bugs1399805
milestone57.0a1
Bug 1399805 - fix the default path of fix_macosx_stack.py for running wpt tests. We try to find fix_macosx_stack.py on the wrong path, which leads us can't run wpt tests without setting stack fix directory manually (--stackfix-dir). In this patch, we fix this issue by pointing the path to @topobjdir/dist/bin. MozReview-Commit-ID: 8JzWWgVM6fM
testing/web-platform/mach_commands.py
--- a/testing/web-platform/mach_commands.py
+++ b/testing/web-platform/mach_commands.py
@@ -41,18 +41,17 @@ class WebPlatformTestsRunnerSetup(Mozbui
 
         if kwargs["prefs_root"] is None:
             kwargs["prefs_root"] = os.path.join(self.topobjdir, '_tests', 'web-platform', "prefs")
 
         if kwargs["certutil_binary"] is None:
             kwargs["certutil_binary"] = self.get_binary_path('certutil')
 
         if kwargs["stackfix_dir"] is None:
-            kwargs["stackfix_dir"] = os.path.split(
-                self.get_binary_path(validate_exists=False))[0]
+            kwargs["stackfix_dir"] = self.bindir
 
         here = os.path.split(__file__)[0]
 
         if kwargs["exclude"] is None and kwargs["include"] is None and not sys.platform.startswith("linux"):
             kwargs["exclude"] = ["css"]
 
         if kwargs["ssl_type"] in (None, "pregenerated"):
             if kwargs["ca_cert_path"] is None: