Sync Bug 1399245: Fix mozilla/normandy#1036: Remove OSX-specific close button CSS for Heartbeat bar. draft
authorMichael Kelly <mkelly@mozilla.com>
Tue, 12 Sep 2017 13:27:12 -0700
changeset 663200 d142107c49c38e6eb2faee8d2f5d9417a3acc794
parent 663134 a73cc4e08bf5a005722c95b43f84ab0c8ff2bc7c
child 663201 72fba2b71040ed668683a46e32d9943d08f5396e
push id79381
push userbmo:mkelly@mozilla.com
push dateTue, 12 Sep 2017 20:45:26 +0000
bugs1399245
milestone57.0a1
Sync Bug 1399245: Fix mozilla/normandy#1036: Remove OSX-specific close button CSS for Heartbeat bar. Due to changes in browser styles for Photon, the fix is no longer necessary, and in fact makes the close button look wrong. Without the fix, the close button looks and behaves the same as the tab bar close buttons. MozReview-Commit-ID: 89tCvQAq1OR
browser/extensions/shield-recipe-client/skin/osx/Heartbeat.css
--- a/browser/extensions/shield-recipe-client/skin/osx/Heartbeat.css
+++ b/browser/extensions/shield-recipe-client/skin/osx/Heartbeat.css
@@ -4,21 +4,8 @@
 
 /* Notification overrides for Heartbeat UI */
 
 notification.heartbeat {
   background-image: linear-gradient(-179deg, #FBFBFB 0%, #EBEBEB 100%) !important;
   border-bottom: 1px solid #C1C1C1 !important;
   height: 40px;
 }
-
-/* In themes/osx/global/notification.css the close icon is inverted because notifications
-   on OSX are usually dark. Heartbeat is light, so override that behaviour. */
-
-notification.heartbeat[type="info"] .close-icon:not(:hover) {
-  -moz-image-region: rect(0, 16px, 16px, 0) !important;
-}
-
-@media (min-resolution: 2dppx) {
-  notification.heartbeat[type="info"] .close-icon:not(:hover) {
-    -moz-image-region: rect(0, 32px, 32px, 0) !important;
-  }
-}