Bug 1397278 - Move the urlbar-go-button node to make its layout work more consistently with other urlbar-icons, and remove obsolete search-go-container padding. r?adw draft
authorDão Gottwald <dao@mozilla.com>
Tue, 12 Sep 2017 15:42:20 +0200
changeset 663011 4faefb787626ed4576e7a5452161be99b58acc18
parent 662980 b0e945eed81db8bf076daf64e381c514f70144f0
child 731059 847acfd9bda91e1a3f1c17aad7af1e4dacd5a9de
push id79283
push userdgottwald@mozilla.com
push dateTue, 12 Sep 2017 13:42:50 +0000
reviewersadw
bugs1397278
milestone57.0a1
Bug 1397278 - Move the urlbar-go-button node to make its layout work more consistently with other urlbar-icons, and remove obsolete search-go-container padding. r?adw MozReview-Commit-ID: 5AHHxey9joo
browser/base/content/urlbarBindings.xml
browser/themes/windows/browser.css
--- a/browser/base/content/urlbarBindings.xml
+++ b/browser/base/content/urlbarBindings.xml
@@ -36,22 +36,22 @@ file, You can obtain one at http://mozil
                   class="textbox-input-box urlbar-input-box"
                   flex="1" xbl:inherits="tooltiptext=inputtooltiptext">
           <children/>
           <html:input anonid="input"
                       class="autocomplete-textbox urlbar-input textbox-input uri-element-right-align"
                       allowevents="true"
                       inputmode="url"
                       xbl:inherits="tooltiptext=inputtooltiptext,value,maxlength,disabled,size,readonly,placeholder,tabindex,accesskey,focused,textoverflow"/>
-          <xul:image anonid="urlbar-go-button"
-                     class="urlbar-go-button urlbar-icon"
-                     onclick="gURLBar.handleCommand(event);"
-                     tooltiptext="&goEndCap.tooltip;"
-                     xbl:inherits="pageproxystate,parentfocused=focused,usertyping"/>
         </xul:hbox>
+        <xul:image anonid="urlbar-go-button"
+                   class="urlbar-go-button urlbar-icon"
+                   onclick="gURLBar.handleCommand(event);"
+                   tooltiptext="&goEndCap.tooltip;"
+                   xbl:inherits="pageproxystate,parentfocused=focused,usertyping"/>
         <xul:dropmarker anonid="historydropmarker"
                         class="autocomplete-history-dropmarker urlbar-history-dropmarker urlbar-icon"
                         tooltiptext="&urlbar.openHistoryPopup.tooltip;"
                         allowevents="true"
                         xbl:inherits="open,enablehistory,parentfocused=focused,usertyping"/>
         <children includes="hbox"/>
       </xul:hbox>
       <xul:popupset anonid="popupset"
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -540,20 +540,16 @@ html|*.urlbar-input:-moz-lwtheme::placeh
   }
 }
 
 #urlbar-zoom-button {
   -moz-appearance: none;
   color: inherit;
 }
 
-.search-go-container {
-  padding: 2px 2px;
-}
-
 #urlbar-search-footer {
   border-top: 1px solid var(--panel-separator-color);
   background-color: var(--arrowpanel-dimmed);
 }
 
 #urlbar-search-settings {
   -moz-appearance: none;
   -moz-user-focus: ignore;