Bug 1394947 fix toggling the extension sidebars from menus, r?zombie draft
authorShane Caraveo <scaraveo@mozilla.com>
Mon, 11 Sep 2017 14:48:18 -0700
changeset 662637 8c614638823a9f8dc4b3b0e8b9c52eadc918136b
parent 662530 b3e449d17d4346dbaa6d3bd5ce689c1ae8170ee0
child 730927 f1dd156ead40419ef06cdca3f9f68ec9eeedfc6a
push id79145
push usermixedpuppy@gmail.com
push dateMon, 11 Sep 2017 21:49:34 +0000
reviewerszombie
bugs1394947
milestone57.0a1
Bug 1394947 fix toggling the extension sidebars from menus, r?zombie MozReview-Commit-ID: G2LGIzSl9Be
browser/components/extensions/ext-sidebarAction.js
--- a/browser/components/extensions/ext-sidebarAction.js
+++ b/browser/components/extensions/ext-sidebarAction.js
@@ -177,17 +177,17 @@ this.sidebarAction = class extends Exten
     broadcaster.setAttribute("autoCheck", "false");
     broadcaster.setAttribute("type", "checkbox");
     broadcaster.setAttribute("group", "sidebar");
     broadcaster.setAttribute("label", details.title);
     broadcaster.setAttribute("sidebarurl", this.sidebarUrl(details.panel));
 
     // oncommand gets attached to menuitem, so we use the observes attribute to
     // get the command id we pass to SidebarUI.
-    broadcaster.setAttribute("oncommand", "SidebarUI.show(this.getAttribute('observes'))");
+    broadcaster.setAttribute("oncommand", "SidebarUI.toggle(this.getAttribute('observes'))");
 
     let header = document.getElementById("sidebar-switcher-target");
     header.addEventListener("SidebarShown", this.updateHeader);
 
     // Insert a menuitem for View->Show Sidebars.
     let menuitem = document.createElementNS(XUL_NS, "menuitem");
     menuitem.setAttribute("id", this.menuId);
     menuitem.setAttribute("observes", this.id);